From owner-svn-src-all@freebsd.org Thu Jun 9 15:11:54 2016 Return-Path: Delivered-To: svn-src-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 46F46AEF41D; Thu, 9 Jun 2016 15:11:54 +0000 (UTC) (envelope-from andrew@fubar.geek.nz) Received: from kif.fubar.geek.nz (kif.fubar.geek.nz [178.62.119.249]) by mx1.freebsd.org (Postfix) with ESMTP id 151D11126; Thu, 9 Jun 2016 15:11:53 +0000 (UTC) (envelope-from andrew@fubar.geek.nz) Received: from zapp (unknown [137.122.64.8]) by kif.fubar.geek.nz (Postfix) with ESMTPSA id 7DAA8D7A17; Thu, 9 Jun 2016 15:11:22 +0000 (UTC) Date: Thu, 9 Jun 2016 11:11:16 -0400 From: Andrew Turner To: Warner Losh Cc: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r301706 - head/sys/boot/efi Message-ID: <20160609111116.38055e82@zapp> In-Reply-To: References: <201606082323.u58NNGsP065228@repo.freebsd.org> X-Mailer: Claws Mail 3.13.2 (GTK+ 2.24.29; amd64-portbld-freebsd11.0) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.22 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 09 Jun 2016 15:11:54 -0000 On Wed, 8 Jun 2016 22:30:15 -0400 Warner Losh wrote: > > On Jun 8, 2016, at 7:23 PM, Andrew Turner > > wrote: > >=20 > > Author: andrew > > Date: Wed Jun 8 23:23:16 2016 > > New Revision: 301706 > > URL: https://svnweb.freebsd.org/changeset/base/301706 > >=20 > > Log: > > Also set -fshort-wchar on arm64, this fixes parsing strings from > > UEFI, e.g. on the command line. =20 >=20 > Maybe this could be used to fix the %S issue instead of the kludge > we=E2=80=99re now doing=E2=80=A6 It may still be needed for arm. The linker checks the compatibility of the attributes so we would need to set -fshort-wchar on all the loader components meaning it would need to be set on all arm loader implementations. Andrew