From owner-cvs-all@FreeBSD.ORG Sat Oct 30 20:09:11 2004 Return-Path: Delivered-To: cvs-all@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 8112916A4CE; Sat, 30 Oct 2004 20:09:11 +0000 (GMT) Received: from imf17aec.mail.bellsouth.net (imf17aec.mail.bellsouth.net [205.152.59.65]) by mx1.FreeBSD.org (Postfix) with ESMTP id 5BBAE43D1D; Sat, 30 Oct 2004 20:09:10 +0000 (GMT) (envelope-from ahze@ahze.net) Received: from [192.168.1.5] ([68.209.163.3]) by imf17aec.mail.bellsouth.netESMTP <20041030200909.NGSB19872.imf17aec.mail.bellsouth.net@[192.168.1.5]>; Sat, 30 Oct 2004 16:09:09 -0400 In-Reply-To: <20041030183014.GC83224@toxic.magnesium.net> References: <200410300322.i9U3MNsA017587@repoman.freebsd.org> <20041030211415.3330b88b.nork@FreeBSD.org> <20041030140559.GB83224@toxic.magnesium.net> <200410301542.i9UFg4pH019425@sakura.ninth-nine.com> <20041030183014.GC83224@toxic.magnesium.net> Mime-Version: 1.0 (Apple Message framework v619) Content-Type: multipart/signed; protocol="application/pgp-signature"; micalg=pgp-sha1; boundary="Apple-Mail-27-600660401" Message-Id: <8C558F09-2AAF-11D9-89A9-000A958C81C6@ahze.net> Content-Transfer-Encoding: 7bit From: Michael Johnson Date: Sat, 30 Oct 2004 16:09:04 -0400 To: Adam Weinberger X-Pgp-Agent: GPGMail 1.0.2 X-Mailer: Apple Mail (2.619) cc: cvs-ports@FreeBSD.org cc: ahze@FreeBSD.org cc: Norikatsu Shigemura cc: cvs-all@FreeBSD.org cc: ports-committers@FreeBSD.org Subject: Re: cvs commit: ports/audio/faac/files patch-gcc X-BeenThere: cvs-all@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the entire tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 30 Oct 2004 20:09:11 -0000 --Apple-Mail-27-600660401 Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset=US-ASCII; format=flowed On Oct 30, 2004, at 2:30 PM, Adam Weinberger wrote: >>> (10.30.2004 @ 1142 PST): Norikatsu Shigemura said, in 1.1K: << >> On Sat, 30 Oct 2004 10:05:59 -0400 >> Adam Weinberger wrote: >>>>> Modified files: >>>>> audio/faac/files patch-gcc >>>>> Log: >>>>> Add missing header to fix build of gstreamer-plugins on >5.x >>>> Thank you. But, please bump PORTREVISION in this case(for >>>> effect to other ports, such as a significant change). >>>>> end of "Re: cvs commit: ports/audio/faac/files patch-gcc" from >>>>> Norikatsu Shigemura << >>> Why? If gst-p wouldn't build before on >5.X, why force 4.X users to >>> rebuild faac to fix a problem they didn't have? It was on my >>> suggestion >>> that he didn't bump PORTREVISION, btw. >> >> If this fix only for faac-self, I don't say that. >> >> Please note, this fix causes that *gst-p* can build >> on >5.x. In my environment, I already updated >> faac before this fix. I was in trouble. But I noticed >> this commit. If I din't update faac *manually*, I >> couldn't update gst-p. >> >> Why not *automatically*? To not rebuild on 4.x users. >> Humm. Don't worry about trifles. If faac isn't >> bumped PORTREVISION, update /usr/ports/UPDATING. Or >> *anyone* can't notice how to fix build error problem >> on gst-p, *officially*. >>> end of "Re: cvs commit: ports/audio/faac/files patch-gcc" from >>> Norikatsu Shigemura << > > I might be misunderstanding, but it seems like you're suggesting that > PORTVERSIONS be bumped to signal that previously unbuildable ports can > now be built. I fail to see who this would benefit in any way. Its not faac that can't be built, its faac.h that other programs use that was causing the problem. > ahze, if faac was unbuildable before, then things are fine the way that > they are. If faac built fine before, but it was only upwardly dependent > ports that could not build, then faac should have a PORTREVISION bump. > Please use this criteria and commit a PORTREVISION bump if need be; you > understand the nature of the changes better than anyone else here. > > # Adam > > > -- > Adam Weinberger > adamw@magnesium.net || adamw@FreeBSD.org > adamw@vectors.cx || adamw@gnome.org > http://www.vectors.cx > _______________________________________________ > cvs-ports@freebsd.org mailing list > http://lists.freebsd.org/mailman/listinfo/cvs-ports > To unsubscribe, send any mail to "cvs-ports-unsubscribe@freebsd.org" --Apple-Mail-27-600660401 content-type: application/pgp-signature; x-mac-type=70674453; name=PGP.sig content-description: This is a digitally signed message part content-disposition: inline; filename=PGP.sig content-transfer-encoding: 7bit -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.2.4 (Darwin) iD8DBQFBg/Tgn4uqfTwEb9YRAqVeAKC/ohPs3Cele6VXquhnGse9IHY9ZACdEQjz SR4/ysEox44O/EgZkpyswMw= =+TGj -----END PGP SIGNATURE----- --Apple-Mail-27-600660401--