From owner-cvs-all Wed Sep 18 22:40:45 2002 Delivered-To: cvs-all@freebsd.org Received: from mx1.FreeBSD.org (mx1.FreeBSD.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id A743D37B401; Wed, 18 Sep 2002 22:40:43 -0700 (PDT) Received: from critter.freebsd.dk (critter.freebsd.dk [212.242.86.163]) by mx1.FreeBSD.org (Postfix) with ESMTP id D404443E3B; Wed, 18 Sep 2002 22:40:42 -0700 (PDT) (envelope-from phk@critter.freebsd.dk) Received: from critter.freebsd.dk (localhost [127.0.0.1]) by critter.freebsd.dk (8.12.6/8.12.6) with ESMTP id g8J5eatF009334; Thu, 19 Sep 2002 07:40:37 +0200 (CEST) (envelope-from phk@critter.freebsd.dk) To: Julian Elischer Cc: Darren Reed , cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/kern uipc_mbuf.c In-Reply-To: Your message of "Wed, 18 Sep 2002 22:17:25 PDT." Date: Thu, 19 Sep 2002 07:40:36 +0200 Message-ID: <9333.1032414036@critter.freebsd.dk> From: Poul-Henning Kamp Sender: owner-cvs-all@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG In message , Ju lian Elischer writes: > > >On Thu, 19 Sep 2002, Poul-Henning Kamp wrote: > >> In message <200209190121.g8J1LPVf041328@freefall.freebsd.org>, Darren Reed writ >> es: >> >darrenr 2002/09/18 18:21:24 PDT >> > >> > Modified files: >> > sys/kern uipc_mbuf.c >> > Log: >> > If M_PKTHDR is set then we don't need to do a loop to find the total length. >> >> This should be backed out. > >Unfortunatly you hit the send key before you included your polite well >thought out reason.. Well, I was inspired by the radically terse, almost ablative commit message I saw the other day: Log: Completely redo thread states. :-) (Yes, I got in quite a hurry when I composed that message.) The reasons for this change being 100% wrong, are so obvious from almost any call to m_length() and from the mbuf(9) man-page, that it isn't really needed to argue about it, it should just be backed out, now, before it hurts anybody. -- Poul-Henning Kamp | UNIX since Zilog Zeus 3.20 phk@FreeBSD.ORG | TCP/IP since RFC 956 FreeBSD committer | BSD since 4.3-tahoe Never attribute to malice what can adequately be explained by incompetence. To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message