From owner-svn-src-all@FreeBSD.ORG  Fri Jan 17 04:40:30 2014
Return-Path: <owner-svn-src-all@FreeBSD.ORG>
Delivered-To: svn-src-all@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org
 [IPv6:2001:1900:2254:206a::19:1])
 (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits))
 (No client certificate requested)
 by hub.freebsd.org (Postfix) with ESMTPS id 865DC354;
 Fri, 17 Jan 2014 04:40:30 +0000 (UTC)
Received: from onelab2.iet.unipi.it (onelab2.iet.unipi.it [131.114.59.238])
 by mx1.freebsd.org (Postfix) with ESMTP id 425DB1C9B;
 Fri, 17 Jan 2014 04:40:30 +0000 (UTC)
Received: by onelab2.iet.unipi.it (Postfix, from userid 275)
 id 7A2C97300A; Fri, 17 Jan 2014 05:42:54 +0100 (CET)
Date: Fri, 17 Jan 2014 05:42:54 +0100
From: Luigi Rizzo <rizzo@iet.unipi.it>
To: hiren panchasara <hiren@FreeBSD.org>
Subject: Re: svn commit: r260700 - in head: sys/dev/netmap tools/tools/netmap
Message-ID: <20140117044254.GB56239@onelab2.iet.unipi.it>
References: <201401160020.s0G0KgwY004039@svn.freebsd.org>
 <CALCpEUFGCb_+w438BaWMGZKH1WwsTL3njLEcv2TPfL0TZ8NFkA@mail.gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <CALCpEUFGCb_+w438BaWMGZKH1WwsTL3njLEcv2TPfL0TZ8NFkA@mail.gmail.com>
User-Agent: Mutt/1.5.20 (2009-06-14)
Cc: svn-src-head <svn-src-head@freebsd.org>, Luigi Rizzo <luigi@freebsd.org>,
 src-committers <src-committers@freebsd.org>,
 svn-src-all <svn-src-all@freebsd.org>
X-BeenThere: svn-src-all@freebsd.org
X-Mailman-Version: 2.1.17
Precedence: list
List-Id: "SVN commit messages for the entire src tree \(except for &quot;
 user&quot; and &quot; projects&quot; \)" <svn-src-all.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/options/svn-src-all>,
 <mailto:svn-src-all-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-src-all/>
List-Post: <mailto:svn-src-all@freebsd.org>
List-Help: <mailto:svn-src-all-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/svn-src-all>,
 <mailto:svn-src-all-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Fri, 17 Jan 2014 04:40:30 -0000

On Thu, Jan 16, 2014 at 12:46:10PM -0800, hiren panchasara wrote:
> On Wed, Jan 15, 2014 at 4:20 PM, Luigi Rizzo <luigi@freebsd.org> wrote:
> > Author: luigi
> > Date: Thu Jan 16 00:20:42 2014
> > New Revision: 260700
> > URL: http://svnweb.freebsd.org/changeset/base/260700
> >
> > Log:
> >   netmap_user.h:
> >      add separate rx/tx ring indexes
> >      add ring specifier in nm_open device name
> >
> >   netmap.c, netmap_vale.c
> >      more consistent errno numbers
> >
> >   netmap_generic.c
> >      correctly handle failure in registering interfaces.
> >
> >   tools/tools/netmap/
> >      massive cleanup of the example programs
> >      (a lot of common code is now in netmap_user.h.)
> >
> >   nm_util.[ch] are going away soon.
> >   pcap.c will also go when i commit the native netmap support for libpcap.
> >
> > Modified:
> >   head/sys/dev/netmap/netmap.c
> >   head/sys/dev/netmap/netmap_generic.c
> >   head/sys/dev/netmap/netmap_vale.c
> >   head/tools/tools/netmap/Makefile
> >   head/tools/tools/netmap/bridge.c
> >   head/tools/tools/netmap/nm_util.c
> >   head/tools/tools/netmap/nm_util.h
> >   head/tools/tools/netmap/pcap.c
> >   head/tools/tools/netmap/pkt-gen.c
> >   head/tools/tools/netmap/vale-ctl.c
> >
> 
> Hi Luigi,
> 
> Doing make in tools/tools/netmap gives me a bunch of errors because
> "struct nm_desc_t" doesn't have members like if_flags, if_reqcap and
> if_curcap. It seems those members were coming from struct my_ring
> which is no more there.

sorry my bad, i forgot to include sys/net/netmap_user.h in the commit.
Fixed in rev 260803

cheers
luigi