From nobody Thu Sep 28 15:52:37 2023 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4RxJ053hpHz4tyR1; Thu, 28 Sep 2023 15:52:37 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4RxJ052mxCz4KvY; Thu, 28 Sep 2023 15:52:37 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1695916357; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=aiG+BVyiKG/kLspx18ZbFEdmiUjI7IKOrNR1CQglw44=; b=xQC3fdL3eKEOKkOQrwCeLArZvVFNt9KyJtwRlHBwmTZRSZO/ZConTH5JAnp13cQdae+DSV SSl++XwcYetejvWF29h66KvEZr7JdYIeOKiI7MA7MJtsta0maomLXCtTHec9HJ/vf7xjMH 3PkuwUlU1SplvWWR77mS6gzrIebvE1QqmG/2+KbTlWa0wmqBUvcq5yNQteVRS6UBSp7ilu CragBMOMslaiZQXLooXhfSa2AWU7VimZEpgtuANG57wCswTrIMIOIYuKGEV/unSqapIs7/ 3PHtuMHBuyxg0CN/kf2H/auB7kgAWpoUmBNiOpGyPT5hltbKw/ttwLTpWelqyA== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1695916357; a=rsa-sha256; cv=none; b=STu2T0nfj/QzWS1vAVyW8Hwlw8WPnjVOGNwU7b1HQuOllSNGZUveV2DD3sEluhXFZIO95J 2RWht/NETLWZitcqp8ViHzJVi0ielRM8Avvvq7+IGUK+YDwet2MlIftJ05fTa0aYilt9Gv fqS/xIS4Z1Sv8i0K3b0fqA7dDWryqoLGpoKioaoFsaozRnAZ7SipoyH71TTj974EYfrU51 RX980PjQANZs1xbRDKFcDdHKXOfB3XCxikdIqTm/Dmyf9qM+4OneWYIV34J1tZQKhn7mmU GhSVaGtd2qfm6F1SxpDh+4Bu7PcfpYODeq3WtmcJzkrEkAMJg4xPdJ7kNxfkkQ== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1695916357; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=aiG+BVyiKG/kLspx18ZbFEdmiUjI7IKOrNR1CQglw44=; b=wKxEHBZu9Qdty6fWD1bYH6DgII4dHsHJQfahlqJFEOC4FbePGqN6P3X8S7U3fvAH+ZdVj+ rXCt726Fc1svtHymUagzkfYt0vYUrseFOktSYh9+6TVx4lUXFu9GFeS04B1PaEQYU4qUym hIKTHPEcvm7LivuxpRYT8vITLk/Bm8LaShCJem13mgWawU5USIOkD7IWPcYtvwuxOzeQyi jCC+v345ta+VKg/CrmDKNsTW+oUX7kU7jgsBSICd0jPeWOVjxgkhhxiiCCMQqETPgYlX12 9zENuTKCds5QsWS8EZUk2LRZCbs0oDrGXsp9MBuKuPc6seznafdygu8J9A7y+w== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4RxJ051rB1zDL8; Thu, 28 Sep 2023 15:52:37 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from gitrepo.freebsd.org ([127.0.1.44]) by gitrepo.freebsd.org (8.17.1/8.17.1) with ESMTP id 38SFqbLK022123; Thu, 28 Sep 2023 15:52:37 GMT (envelope-from git@gitrepo.freebsd.org) Received: (from git@localhost) by gitrepo.freebsd.org (8.17.1/8.17.1/Submit) id 38SFqb94022120; Thu, 28 Sep 2023 15:52:37 GMT (envelope-from git) Date: Thu, 28 Sep 2023 15:52:37 GMT Message-Id: <202309281552.38SFqb94022120@gitrepo.freebsd.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org From: Mark Johnston Subject: git: cd90f3afb72a - main - syslogd: Do not print bad data List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-src-all@freebsd.org X-BeenThere: dev-commits-src-all@freebsd.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: markj X-Git-Repository: src X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: cd90f3afb72a31415996fffd46026a74d64124ea Auto-Submitted: auto-generated The branch main has been updated by markj: URL: https://cgit.FreeBSD.org/src/commit/?id=cd90f3afb72a31415996fffd46026a74d64124ea commit cd90f3afb72a31415996fffd46026a74d64124ea Author: Jake Freeland AuthorDate: 2023-09-01 02:50:35 +0000 Commit: Mark Johnston CommitDate: 2023-09-28 15:51:53 +0000 syslogd: Do not print bad data If errno is zero, then buf is never filled and we're printing uninitialized data. Print the msg buffer instead to mitigate this. Reviewed by: markj, emaste MFC after: 3 weeks Sponsored by: The FreeBSD Foundation Differential Revision: https://reviews.freebsd.org/D41371 --- usr.sbin/syslogd/syslogd.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/usr.sbin/syslogd/syslogd.c b/usr.sbin/syslogd/syslogd.c index a37f3a9482bf..c63683efead6 100644 --- a/usr.sbin/syslogd/syslogd.c +++ b/usr.sbin/syslogd/syslogd.c @@ -2314,7 +2314,7 @@ logerror(const char *msg) msg = buf; } errno = 0; - dprintf("%s\n", buf); + dprintf("%s\n", msg); logmsg(LOG_SYSLOG|LOG_ERR, NULL, LocalHostName, "syslogd", NULL, NULL, NULL, msg, 0); recursed--;