From owner-freebsd-net@FreeBSD.ORG Sun Nov 1 09:09:20 2009 Return-Path: Delivered-To: net@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 64AC3106568B; Sun, 1 Nov 2009 09:09:20 +0000 (UTC) (envelope-from onemda@gmail.com) Received: from fg-out-1718.google.com (fg-out-1718.google.com [72.14.220.159]) by mx1.freebsd.org (Postfix) with ESMTP id CA9308FC1D; Sun, 1 Nov 2009 09:09:19 +0000 (UTC) Received: by fg-out-1718.google.com with SMTP id d23so156665fga.13 for ; Sun, 01 Nov 2009 01:09:18 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:mime-version:received:in-reply-to:references :date:message-id:subject:from:to:cc:content-type; bh=Fu1A4D5iIIY4lh0a3YeOBFsE/fVc4ORQbyqpGy5GEpg=; b=ipR1spB5qPbyGHN521HBLOApLtWeCsh9edWUFj4TSRYBrT8Vrr9cFVEkmiG68oaIWO BJMeeBYVKtYj1J7ohyLzQy2o1q9TtGMC4wl20/zpmg4UBJE920XiqbNSeNo+0or64Tts kBW6QW/fLBrOUZQTcgbWHuA+0V1I5Pk9PmJsg= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type; b=js/c2FKeiz3yl9/gY8pmdQZ8Fm3r5Aadn2eIRyK3kMxmq9iN8MVthCYoyALiRoDVO1 TML7Vdhw1ecxc0HI0U+65nsDRr4zK3x5MpL/zTyNSqekNdykMl2+3x6+3OGgJzWwsgsQ 95xe8oKxYH2OIIBHCRJhh6bidNjwohG9NFvA0= MIME-Version: 1.0 Received: by 10.103.50.32 with SMTP id c32mr1497499muk.1.1257066558484; Sun, 01 Nov 2009 01:09:18 -0800 (PST) In-Reply-To: <1257014422.2113.6.camel@localhost> References: <3a142e750910300852n276d009bsefea73b3ee4db176@mail.gmail.com> <1257014422.2113.6.camel@localhost> Date: Sun, 1 Nov 2009 10:09:18 +0100 Message-ID: <3a142e750911010109t7d1c9148t264e168a3a2bd47a@mail.gmail.com> From: Paul B Mahol To: Coleman Kane Content-Type: text/plain; charset=ISO-8859-1 Cc: net@freebsd.org Subject: Re: if_ndis patch X-BeenThere: freebsd-net@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Networking and TCP/IP with FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 01 Nov 2009 09:09:20 -0000 On 10/31/09, Coleman Kane wrote: > Paul, > > Did you get to send this to sam@, etc ? Negative, now let @net know about it too. > On Fri, 2009-10-30 at 16:52 +0100, Paul B Mahol wrote: >> Hi, >> >> There is no point to do scanning how it is currently done: >> >> Index: if_ndis.c >> =================================================================== >> --- if_ndis.c (revision 198675) >> +++ if_ndis.c (working copy) >> @@ -3398,11 +3398,8 @@ >> struct ifnet *ifp = ic->ic_ifp; >> struct ndis_softc *sc = ifp->if_softc; >> struct ieee80211vap *vap; >> - struct ieee80211_scan_state *ss; >> - ndis_80211_ssid ssid; >> int error, len; >> >> - ss = ic->ic_scan; >> vap = TAILQ_FIRST(&ic->ic_vaps); >> >> if (!NDIS_INITIALIZED(sc)) { >> @@ -3411,20 +3408,6 @@ >> return; >> } >> >> - len = sizeof(ssid); >> - bzero((char *)&ssid, len); >> - if (ss->ss_nssid == 0) >> - ssid.ns_ssidlen = 1; >> - else { >> - /* Perform a directed scan */ >> - ssid.ns_ssidlen = ss->ss_ssid[0].len; >> - bcopy(ss->ss_ssid[0].ssid, ssid.ns_ssid, ssid.ns_ssidlen); >> - } >> - >> - error = ndis_set_info(sc, OID_802_11_SSID, &ssid, &len); >> - if (error) >> - DPRINTF(("%s: set ESSID failed\n", __func__)); >> - >> len = 0; >> error = ndis_set_info(sc, OID_802_11_BSSID_LIST_SCAN, >> NULL, &len);