From owner-cvs-all@FreeBSD.ORG Fri Mar 24 22:32:15 2006 Return-Path: X-Original-To: cvs-all@FreeBSD.org Delivered-To: cvs-all@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id AC6F016A401; Fri, 24 Mar 2006 22:32:15 +0000 (UTC) (envelope-from jasone@FreeBSD.org) Received: from lh.synack.net (lh.synack.net [204.152.188.37]) by mx1.FreeBSD.org (Postfix) with ESMTP id 31CF743D48; Fri, 24 Mar 2006 22:32:15 +0000 (GMT) (envelope-from jasone@FreeBSD.org) Received: by lh.synack.net (Postfix, from userid 100) id E0CC75E4911; Fri, 24 Mar 2006 14:32:14 -0800 (PST) Received: from [192.168.168.201] (moscow-cuda-gen2-68-64-60-20.losaca.adelphia.net [68.64.60.20]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by lh.synack.net (Postfix) with ESMTP id 7096A5E48BA; Fri, 24 Mar 2006 14:32:13 -0800 (PST) Message-ID: <4424736B.2020609@FreeBSD.org> Date: Fri, 24 Mar 2006 14:32:11 -0800 From: Jason Evans User-Agent: Mozilla Thunderbird 1.0.7-1.4.1 (X11/20050929) X-Accept-Language: en-us, en MIME-Version: 1.0 References: <200603242213.k2OMDodV024004@repoman.freebsd.org> In-Reply-To: <200603242213.k2OMDodV024004@repoman.freebsd.org> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Checker-Version: SpamAssassin 3.0.5 (2005-11-28) on lh.synack.net X-Spam-Level: * X-Spam-Status: No, score=1.8 required=5.0 tests=RCVD_IN_NJABL_DUL, RCVD_IN_SORBS_DUL autolearn=no version=3.0.5 Cc: cvs-src@FreeBSD.org, src-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/lib/libc/stdlib malloc.c X-BeenThere: cvs-all@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the entire tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 24 Mar 2006 22:32:15 -0000 Jason Evans wrote: > jasone 2006-03-24 22:13:49 UTC > > FreeBSD src repository > > Modified files: > lib/libc/stdlib malloc.c > Log: > Convert TINY_MIN_2POW from a cpp macro to tiny_min_2pow (a variable), and > determine its value at run time according to other relevant values. This > avoids the creation of runs that are incompletely utilized, as long as > pagesize isn't too large (>32kB, given the current RUN_MIN_REGS_2POW > setting). > > Increase the size of several structure bitfields in arena_run_t in order > to avoid integer overflow in the case that a run's header does not overlap > with the space that is usable as application allocation regions. Given > the tiny_min_2pow change, this fix has no additional impact unless > pagesize is >32kB. > > Reported by: kris > > Revision Changes Path > 1.116 +37 -21 src/lib/libc/stdlib/malloc.c > > http://www.FreeBSD.org/cgi/cvsweb.cgi/src/lib/libc/stdlib/malloc.c.diff?&r1=1.115&r2=1.116&f=H It isn't obvious from the commit log message that this change (hopefully) fixes malloc on sparc64, ia64, and alpha, all of which use 8kB pages. So, be warned, if you are updating -current for one of those architectures, do *not* use revisions 1.112 through 1.115 of src/lib/libc/stdlib/malloc.c. Jason