From owner-svn-ports-all@freebsd.org Thu Aug 24 12:18:40 2017 Return-Path: Delivered-To: svn-ports-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 9E8F6DDE2DD; Thu, 24 Aug 2017 12:18:40 +0000 (UTC) (envelope-from thierry@pompo.net) Received: from edna.lautre.net (edna.lautre.net [80.67.160.88]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client CN "*.lautre.net", Issuer "COMODO RSA Domain Validation Secure Server CA" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id C456775885; Thu, 24 Aug 2017 12:18:38 +0000 (UTC) (envelope-from thierry@pompo.net) Received: from graf.pompo.net (graf.pompo.net [78.225.128.39]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by edna.lautre.net (Postfix) with ESMTPSA id 4BAE42B5E; Thu, 24 Aug 2017 14:12:32 +0200 (CEST) Received: by graf.pompo.net (Postfix, from userid 1001) id B35291B9F9B; Thu, 24 Aug 2017 14:12:32 +0200 (CEST) Date: Thu, 24 Aug 2017 14:12:32 +0200 From: Thierry Thomas To: Romain =?iso-8859-1?Q?Tarti=E8re?= Cc: Baptiste Daroussin , ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org, sobomax@FreeBSD.org Subject: Re: svn commit: r448610 - in head/devel/leatherman: . files Message-ID: <20170824121232.GA31945@graf.pompo.net> Mail-Followup-To: Romain =?iso-8859-1?Q?Tarti=E8re?= , Baptiste Daroussin , ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org, sobomax@FreeBSD.org References: <201708231317.v7NDHEGS099253@repo.freebsd.org> <20170823132505.s7kakyqgyb5tdy42@ivaldir.net> <20170823134551.GA13824@blogreen.org> <20170823134934.rjje72qwomm7sd6c@ivaldir.net> <20170823140836.GB13824@blogreen.org> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="LZvS9be/3tNcYl/X" Content-Disposition: inline In-Reply-To: <20170823140836.GB13824@blogreen.org> X-Operating-System: FreeBSD 11.1-STABLE amd64 Organization: Kabbale Eros X-Face: (hRbQnK~Pt7$ct`!fupO(`y_WL4^-Iwn4@ly-.,[4xC4xc; y=\ipKMNm<1J>lv@PP~7Z<.t KjAnXLs: X-PGP: 0xF1C516B3C8359753 User-Agent: Mutt/1.6.1 (2016-04-27) X-BeenThere: svn-ports-all@freebsd.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: SVN commit messages for the ports tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 24 Aug 2017 12:18:40 -0000 --LZvS9be/3tNcYl/X Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Le mer. 23 ao=FBt 17 =E0 16:08:36 +0200, Romain Tarti=E8re =E9crivait=A0: > Another point with `make makepatch`: in the post-patch target, I alter > the patched source code. `make makepatch` wants the combined patches to > be combined: >=20 > ---------------------------------- 8< ---------------------------------- > -+ return "%%PREFIX%%/etc/facter/facter.conf"; > ++ return "/usr/local/etc/facter/facter.conf"; > ---------------------------------- 8< ---------------------------------- This is why this kind of substitutions are better in pre-configure. Logically, post-patch is for static replacements, not for variables depending on the configuration options. --=20 Th. Thomas. --LZvS9be/3tNcYl/X Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQJ8BAEBCgBmBQJZnsKwXxSAAAAAAC4AKGlzc3Vlci1mcHJAbm90YXRpb25zLm9w ZW5wZ3AuZmlmdGhob3JzZW1hbi5uZXRFNTM2QkU4NTM4NTM5OUQwMEI2RkFBNzZG MUM1MTZCM0M4MzU5NzUzAAoJEPHFFrPINZdTz1EP/0dp/IF69cPOZHViEj6PlhJb mr1iie4haQSVsBmHVJpBNPUzvii9I2SYh1W5BfeWf1s9AfLtgJKfYIjsQMXuxghP ahYkwlKeVur81TmzsRvaR6SCKQjc7Sa3yGDI5/G8z2YN5xlmDiTKs1NGR5iweVem w52z/LNnEDP0tQJnKfGMmnWe/Y+AIEnYVe3m06qLt3RUB+7vNX2QEr6Zk8AhKggR 4NH5D91QewKSDuiN5uAE1qSCIhYi34ZcwHWGhRzJcS5Vo41fzAu+LeUeDy9PZs4r KLg9zSVeYnbkptbpTfplp29MemyUXu15NCfDlWDVNsCliXwEOwAM4L6gCCTdVlx0 gVsccXWwnZ9AkK6ToYzqQwbCXjENVC7creKedkC3xEXKT+J673y5Mj3MohHionex NiaF9ub9WNVm4bAS5EhKdAndVajaCD6i5k0xbOn9J2xZ8PidjuRjPZAARxrb8MtI 7uc7fj8sP8C6YGwzVl0kXUxvxQiKDnN8GRl2iqbnTjQ3UTleSf2NSEThaAK8WoIe PjcP9daVTVUgiR12tD20Pa80zGxtiH8V7qHgNCrGNGEYy0eQtWEvH8jtptDaH7MT XUL32orvuBQg93rvbTrVBGQnKOytG4uDOOzVlk16L3YZq52hK2vk8CE7o43S8ujG rj/ScpKSqy9XYe5KS3Ss =BU7n -----END PGP SIGNATURE----- --LZvS9be/3tNcYl/X--