Date: Sat, 31 Aug 2002 22:00:05 -0700 (PDT) From: =?koi8-r?B?4c7E0sXKIP7F0s7P1w==?= <ache@nagual.pp.ru> To: freebsd-bugs@FreeBSD.org Subject: Re: bin/35812: strings(1) does'n print russian characters Message-ID: <200209010500.g81505Oi097017@freefall.freebsd.org>
next in thread | raw e-mail | index | archive | help
The following reply was made to PR bin/35812; it has been noted by GNATS.
From: =?koi8-r?B?4c7E0sXKIP7F0s7P1w==?= <ache@nagual.pp.ru>
To: "."@babolo.ru
Cc: David Malone <dwmalone@FreeBSD.ORG>, gpr@nvnpp.vrn.ru,
freebsd-bugs@FreeBSD.ORG, bug-followup@FreeBSD.ORG
Subject: Re: bin/35812: strings(1) does'n print russian characters
Date: Sun, 1 Sep 2002 08:55:05 +0400
On Sun, Sep 01, 2002 at 08:40:04 +0400, "."@babolo.ru wrote:
> David Malone writes:
> > Synopsis: strings(1) does'n print russian characters
> >
> > State-Changed-From-To: open->closed
> > State-Changed-By: dwmalone
> > State-Changed-When: Sat Aug 31 15:48:27 PDT 2002
> > State-Changed-Why:
> > Submitter reckons PR can be closed (as a binutils issue at heart).
> Without strings(1) patched?
> I understand (may be) binutils issue, but
> my patch bypass this issue.
> (there was a little error in my previous patch)
>
> --- usr.bin/strings/strings.c Mon Apr 23 02:38:13 2001
> +++ usr.bin/strings/strings.c Wed Aug 22 05:05:04 2001
> @@ -170,7 +170,7 @@
> }
> start:
> for (cnt = 0; (ch = getch()) != EOF;) {
> - if (ISSTR(ch)) {
> + if (ISSTR(ch & 0xff)) {
This patch:
1) Applies to source code not used for ELF binaries.
2) Not change anything there (ch is already without sign extension).
--
Andrey A. Chernov
http://ache.pp.ru/
To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe freebsd-bugs" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200209010500.g81505Oi097017>