From owner-cvs-src@FreeBSD.ORG Tue May 27 20:18:39 2003 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id B8F8837B401; Tue, 27 May 2003 20:18:39 -0700 (PDT) Received: from magic.adaptec.com (magic-mail.adaptec.com [208.236.45.100]) by mx1.FreeBSD.org (Postfix) with ESMTP id 2781D43FAF; Tue, 27 May 2003 20:18:39 -0700 (PDT) (envelope-from scott_long@btc.adaptec.com) Received: from redfish.adaptec.com (redfish.adaptec.com [162.62.50.11]) by magic.adaptec.com (8.11.6/8.11.6) with ESMTP id h4S3E0Z06446; Tue, 27 May 2003 20:14:00 -0700 Received: from btc.adaptec.com (hollin.btc.adaptec.com [10.100.253.56]) by redfish.adaptec.com (8.8.8p2+Sun/8.8.8) with ESMTP id UAA29263; Tue, 27 May 2003 20:18:33 -0700 (PDT) Message-ID: <3ED429E8.2080205@btc.adaptec.com> Date: Tue, 27 May 2003 21:15:52 -0600 From: Scott Long User-Agent: Mozilla/5.0 (X11; U; FreeBSD i386; en-US; rv:1.3) Gecko/20030414 X-Accept-Language: en-us, en MIME-Version: 1.0 To: Mike Silbersack References: <200305280204.h4S24X8K070813@repoman.freebsd.org> In-Reply-To: <200305280204.h4S24X8K070813@repoman.freebsd.org> Content-Type: text/plain; charset=us-ascii; format=flowed Content-Transfer-Encoding: 7bit cc: cvs-src@FreeBSD.org cc: src-committers@FreeBSD.org cc: cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/net if_loop.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 28 May 2003 03:18:40 -0000 Mike Silbersack wrote: > silby 2003/05/27 19:04:33 PDT > > FreeBSD src repository > > Modified files: > sys/net if_loop.c > Log: > Replace a handrolled defrag function with m_defrag. The handrolled > function couldn't handle chains of > MCLBYTES, and it had a bug which > caused corruption and panics in certain low mbuf situations. > > Additionally, change the failure case so that looutput returns ENOBUFS > rather than attempting to pass on non-defragmented mbuf chains. > > Finally, remove the printf which would happen every time the low memory > situation occured. It served no useful purpose other than to clue me > in as to what was causing the panic in question. :) > > MFC after: 4 days > > Revision Changes Path > 1.83 +14 -21 src/sys/net/if_loop.c Don't forget that this was approved by re@ =-)