From owner-cvs-src@FreeBSD.ORG Sun Sep 5 23:30:22 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 211C916A4CF for ; Sun, 5 Sep 2004 23:30:22 +0000 (GMT) Received: from c00l3r.networx.ch (c00l3r.networx.ch [62.48.2.2]) by mx1.FreeBSD.org (Postfix) with ESMTP id 32D4A43D3F for ; Sun, 5 Sep 2004 23:30:21 +0000 (GMT) (envelope-from andre@freebsd.org) Received: (qmail 27015 invoked from network); 5 Sep 2004 23:27:19 -0000 Received: from unknown (HELO freebsd.org) ([62.48.0.54]) (envelope-sender ) by c00l3r.networx.ch (qmail-ldap-1.03) with SMTP for ; 5 Sep 2004 23:27:19 -0000 Message-ID: <413BA18C.D7A35736@freebsd.org> Date: Mon, 06 Sep 2004 01:30:20 +0200 From: Andre Oppermann X-Mailer: Mozilla 4.8 [en] (Windows NT 5.0; U) X-Accept-Language: en MIME-Version: 1.0 To: Gleb Smirnoff References: <200409052006.i85K6ovn042219@repoman.freebsd.org> <413B8C06.CBC43282@freebsd.org> <20040905230743.GA82892@cell.sick.ru> Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit cc: cvs-src@freebsd.org cc: src-committers@freebsd.org cc: cvs-all@freebsd.org Subject: Re: cvs commit: src/sys/netinet ip_fw2.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 05 Sep 2004 23:30:22 -0000 Gleb Smirnoff wrote: > > On Sun, Sep 05, 2004 at 11:58:30PM +0200, Andre Oppermann wrote: > A> Thanks. I was at the SUCON'04 the last days and only infrequently checking > A> my inbox. The ipfw2 code never returned EINVAL for divert actions when the > A> IPDIVERT was not compiled in. I didn't change that with the conversion to > A> pfil_hooks. > > May be this check was in other place. I clearly remeber that rc.firewall > on my 4.x boxes produced errors on divert with GENERIC loaded. > > I haven't looked at code but I have just checked: > > root@fade:~:|>ipfw add 65000 divert natd all from any to any > ipfw: getsockopt(IP_FW_ADD): Invalid argument > root@fade:~:|>uname -a > FreeBSD fade.bestcom.ru 4.9-STABLE FreeBSD 4.9-STABLE #3: Mon Jan 12 12:30:42 MSK 2004 root@fade.bestcom.ru:/usr/obj/usr/src/sys/FADE i386 > > (no DIVERT in kernel). Is that ipfw or ipfw2 (ipfw != ipfw2)? Anyway, if ipfw behaved this way on 4.x it should continue to do so in 5.x. So your change is correct. -- Andre