From owner-freebsd-current@FreeBSD.ORG Thu Aug 19 18:08:43 2004 Return-Path: Delivered-To: freebsd-current@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 4EED016A4CE for ; Thu, 19 Aug 2004 18:08:43 +0000 (GMT) Received: from mail5.speakeasy.net (mail5.speakeasy.net [216.254.0.205]) by mx1.FreeBSD.org (Postfix) with ESMTP id 2508843D46 for ; Thu, 19 Aug 2004 18:08:43 +0000 (GMT) (envelope-from jmg@hydrogen.funkthat.com) Received: (qmail 30632 invoked from network); 19 Aug 2004 18:08:42 -0000 Received: from gate.funkthat.com (HELO hydrogen.funkthat.com) ([69.17.45.168]) (envelope-sender ) by mail5.speakeasy.net (qmail-ldap-1.03) with SMTP for ; 19 Aug 2004 18:08:42 -0000 Received: from hydrogen.funkthat.com (bkvenm@localhost.funkthat.com [127.0.0.1])i7JI8fuU076568; Thu, 19 Aug 2004 11:08:42 -0700 (PDT) (envelope-from jmg@hydrogen.funkthat.com) Received: (from jmg@localhost) by hydrogen.funkthat.com (8.12.10/8.12.10/Submit) id i7JI8ebo076567; Thu, 19 Aug 2004 11:08:40 -0700 (PDT) Date: Thu, 19 Aug 2004 11:08:40 -0700 From: John-Mark Gurney To: Sean McNeil Message-ID: <20040819180840.GV99980@funkthat.com> Mail-Followup-To: Sean McNeil , Andre Oppermann , freebsd-current@FreeBSD.org, John Baldwin References: <1092881027.999.3.camel@server.mcneil.com> <412497B5.6040203@freebsd.org> <4124D1D4.5080307@samsco.org> <200408191251.32319.jhb@FreeBSD.org> <4124E1DA.B5341C04@freebsd.org> <1092938019.79038.4.camel@server.mcneil.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1092938019.79038.4.camel@server.mcneil.com> User-Agent: Mutt/1.4.1i X-Operating-System: FreeBSD 4.2-RELEASE i386 X-PGP-Fingerprint: B7 EC EF F8 AE ED A7 31 96 7A 22 B3 D8 56 36 F4 X-Files: The truth is out there X-URL: http://resnet.uoregon.edu/~gurney_j/ X-Resume: http://resnet.uoregon.edu/~gurney_j/resume.html cc: freebsd-current@freebsd.org cc: Andre Oppermann Subject: Re: kernel module options (was ipfw2 broken) X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list Reply-To: John-Mark Gurney List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 19 Aug 2004 18:08:43 -0000 Sean McNeil wrote this message on Thu, Aug 19, 2004 at 10:53 -0700: > On Thu, 2004-08-19 at 10:22, Andre Oppermann wrote: > > IPDIVERT wasn't compiled into the module before. It's surrounded by > > #if !defined(KLD_MODULE). However if the kernel was compiled with option > > IPDIVERT but w/o IPFIREWALL is was working anyway. > > Has this changed? From what I saw yesterday no option in my config file > could possibly effect the compilation of the ipfw2 module. The only way > I could see doing it was to modify the Makefile for the module. yuk. > > I would like to see a general mechanism supported to turn on various > options within a module build. Would it be possible to fix module > building to honor options from the config? I had a set of changes a while back that would link all of the opt_*.h files in the various module's dirs back to the ones in the main kernel compile assuming that there wasn't a specific rule in the Makefile to build that file. I.e. 99% of the opt_*.h rules could be eliminated. This solution was decided to be inadaquate, and was not accepted, but I again propose it. It quick and easy. -- John-Mark Gurney Voice: +1 415 225 5579 "All that I will do, has been done, All that I have, has not."