From owner-freebsd-ports@FreeBSD.ORG  Wed Apr  1 07:30:35 2015
Return-Path: <owner-freebsd-ports@FreeBSD.ORG>
Delivered-To: ports@FreeBSD.org
Received: from mx1.freebsd.org (mx1.freebsd.org
 [IPv6:2001:1900:2254:206a::19:1])
 (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))
 (No client certificate requested)
 by hub.freebsd.org (Postfix) with ESMTPS id 9810A493;
 Wed,  1 Apr 2015 07:30:35 +0000 (UTC)
Received: from gw.catspoiler.org (cl-1657.chi-02.us.sixxs.net
 [IPv6:2001:4978:f:678::2])
 (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits))
 (Client did not present a certificate)
 by mx1.freebsd.org (Postfix) with ESMTPS id 27F44EC6;
 Wed,  1 Apr 2015 07:30:35 +0000 (UTC)
Received: from FreeBSD.org (mousie.catspoiler.org [192.168.101.2])
 by gw.catspoiler.org (8.13.3/8.13.3) with ESMTP id t317UQTX002225;
 Tue, 31 Mar 2015 23:30:30 -0800 (PST)
 (envelope-from truckman@FreeBSD.org)
Message-Id: <201504010730.t317UQTX002225@gw.catspoiler.org>
Date: Wed, 1 Apr 2015 00:30:26 -0700 (PDT)
From: Don Lewis <truckman@FreeBSD.org>
Subject: Re: github tags containing "/"
To: bdrewery@FreeBSD.org
In-Reply-To: <551B9D24.5060200@FreeBSD.org>
MIME-Version: 1.0
Content-Type: TEXT/plain; charset=us-ascii
Cc: ports@FreeBSD.org
X-BeenThere: freebsd-ports@freebsd.org
X-Mailman-Version: 2.1.18-1
Precedence: list
List-Id: Porting software to FreeBSD <freebsd-ports.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/options/freebsd-ports>,
 <mailto:freebsd-ports-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-ports/>
List-Post: <mailto:freebsd-ports@freebsd.org>
List-Help: <mailto:freebsd-ports-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-ports>,
 <mailto:freebsd-ports-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Wed, 01 Apr 2015 07:30:35 -0000

On  1 Apr, Bryan Drewery wrote:
> On 4/1/2015 2:13 AM, Don Lewis wrote:
>> On  1 Apr, Bryan Drewery wrote:
>>> On 4/1/2015 1:54 AM, Don Lewis wrote:
>>>> I'm working on a couple of new ports where I'm using fetching the
>>>> distfiles from github.  One quirk is that the tags start with a prefix
>>>> of "tags/v".  I'm setting PKGNAMEPREFIX=${PYTHON_PKGNAMEPREFIX}.
> 
> Wow it really has 'tags/' in the tags and 'branches/' in the branches.
> It has to be a bad conversion from SVN. Anyway it is intended to be
> supported fine...

Yeah, trying to get "make fetch" working was quite entertaining.

>>>>
>>>> If I follow the example for in the Porters Handbook using
>>>> DISTVERSIONPREFIX=tags/v then the distfile gets named
>>>> ${PORTNAME}-tags/v${PORTVERSION}_GH0.tar.gz,
>>>> which seems somewhat undesirable.  This seems to be a bit misleading
>>>> and risky because this port is just a python wrapper around another
>>>> library that also has the same PORTNAME.  That port hasn't been
>>>> converted to fetch from github, and when it does it seems like there
>>>> would be a chance of collisions.
>>>>
>>>> I seem to get better results by setting GH_TAGNAME=tags/v${PORTVERSION}.
>>>> In that case, the distfile gets named
>>>> ${GH_ACCOUNT}-${GH_PROJECT}-${PORTVERSION}-tags-v${PORTVERSION}_GH0.tar.gz.
>>>> This seems to be excessively verbose, but safer.
> 
> Just use GH_TAGNAME=tags/v${PORTVERSION} for now.

Ok, will do.

> The DISTVERSIONPREFIX is supposed to work in this case as well. I'll
> look into it tomorrow.
> 
> It is likely the same as
> https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=199069 which I
> realized earlier today.
> 
> The DISTNAME you see is intentionally verbose so it is unique and avoids
> rerolled checksums on account/project renames or PORTVERSION changes or
> github-specific rerolls. It is intended to stand out as a
> GITHUB-generated file so it is not confused with other distributed files.
> 
> The DISTVERSIONPREFIX _not_ producing the same filename is a bug.

Thanks!