From owner-cvs-all Sat Apr 20 8:32:12 2002 Delivered-To: cvs-all@freebsd.org Received: from nagual.pp.ru (pobrecita.freebsd.ru [194.87.13.42]) by hub.freebsd.org (Postfix) with ESMTP id 42E1837B416; Sat, 20 Apr 2002 08:32:05 -0700 (PDT) Received: from pobrecita.freebsd.ru (ache@localhost [127.0.0.1]) by nagual.pp.ru (8.12.2/8.12.2) with ESMTP id g3KFW2iJ006337; Sat, 20 Apr 2002 19:32:04 +0400 (MSD) (envelope-from ache@pobrecita.freebsd.ru) Received: (from ache@localhost) by pobrecita.freebsd.ru (8.12.3/8.12.2/Submit) id g3KFW21x006336; Sat, 20 Apr 2002 19:32:02 +0400 (MSD) Date: Sat, 20 Apr 2002 19:32:02 +0400 From: "Andrey A. Chernov" To: Dag-Erling Smorgrav Cc: cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/crypto/openssh session.c Message-ID: <20020420153202.GB6166@nagual.pp.ru> References: <200204200956.g3K9uAM11914@freefall.freebsd.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.3.28i Sender: owner-cvs-all@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG On Sat, Apr 20, 2002 at 17:19:02 +0200, Dag-Erling Smorgrav wrote: > Dag-Erling Smorgrav writes: > > "Andrey A. Chernov" writes: > > > Log: > > > Fix TZ & TERM handling for use_login case of rev. 1.24 > > This patch is incorrect. It will cause a segmentation fault if TZ is > > not defined, which is the case for most people. Please back it out. > > Sorry, this comment applies to 1.24, and 1.26 fixes it. Your comment not applies even to 1.24 :-) if (getenv("TZ")) check present in all variants. What 1.24 (without 1.26) does is forget to set those variables for use_login case. -- Andrey A. Chernov http://ache.pp.ru/ To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message