From owner-svn-src-head@freebsd.org  Fri Jan 19 18:40:51 2018
Return-Path: <owner-svn-src-head@freebsd.org>
Delivered-To: svn-src-head@mailman.ysv.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org
 [IPv6:2001:1900:2254:206a::19:1])
 by mailman.ysv.freebsd.org (Postfix) with ESMTP id E55B0EC121A;
 Fri, 19 Jan 2018 18:40:51 +0000 (UTC)
 (envelope-from freebsd@pdx.rh.CN85.dnsmgr.net)
Received: from pdx.rh.CN85.dnsmgr.net (br1.CN84in.dnsmgr.net [69.59.192.140])
 (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits))
 (Client did not present a certificate)
 by mx1.freebsd.org (Postfix) with ESMTPS id CA7B06E3C3;
 Fri, 19 Jan 2018 18:40:51 +0000 (UTC)
 (envelope-from freebsd@pdx.rh.CN85.dnsmgr.net)
Received: from pdx.rh.CN85.dnsmgr.net (localhost [127.0.0.1])
 by pdx.rh.CN85.dnsmgr.net (8.13.3/8.13.3) with ESMTP id w0JIenmn073387;
 Fri, 19 Jan 2018 10:40:49 -0800 (PST)
 (envelope-from freebsd@pdx.rh.CN85.dnsmgr.net)
Received: (from freebsd@localhost)
 by pdx.rh.CN85.dnsmgr.net (8.13.3/8.13.3/Submit) id w0JIenJ3073386;
 Fri, 19 Jan 2018 10:40:49 -0800 (PST) (envelope-from freebsd)
From: "Rodney W. Grimes" <freebsd@pdx.rh.CN85.dnsmgr.net>
Message-Id: <201801191840.w0JIenJ3073386@pdx.rh.CN85.dnsmgr.net>
Subject: Re: svn commit: r328159 - head/sys/modules
In-Reply-To: <2915608.v56yfz43Ej@ralph.baldwin.cx>
To: John Baldwin <jhb@freebsd.org>
Date: Fri, 19 Jan 2018 10:40:49 -0800 (PST)
CC: Conrad Meyer <cem@freebsd.org>, src-committers@freebsd.org,
 svn-src-all@freebsd.org, svn-src-head@freebsd.org
Reply-To: rgrimes@freebsd.org
X-Mailer: ELM [version 2.4ME+ PL121h (25)]
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
Content-Type: text/plain; charset=US-ASCII
X-BeenThere: svn-src-head@freebsd.org
X-Mailman-Version: 2.1.25
Precedence: list
List-Id: SVN commit messages for the src tree for head/-current
 <svn-src-head.freebsd.org>
List-Unsubscribe: <https://lists.freebsd.org/mailman/options/svn-src-head>,
 <mailto:svn-src-head-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-src-head/>
List-Post: <mailto:svn-src-head@freebsd.org>
List-Help: <mailto:svn-src-head-request@freebsd.org?subject=help>
List-Subscribe: <https://lists.freebsd.org/mailman/listinfo/svn-src-head>,
 <mailto:svn-src-head-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Fri, 19 Jan 2018 18:40:52 -0000

> On Friday, January 19, 2018 04:34:06 AM Conrad Meyer wrote:
> > Author: cem
> > Date: Fri Jan 19 04:34:06 2018
> > New Revision: 328159
> > URL: https://svnweb.freebsd.org/changeset/base/328159
> > 
> > Log:
> >   Unbreak i386 build
> >   
> >   The logical result of a right shift >= the width of a type is zero, but our
> >   compiler decides this is a warning (and thus, error).  Just remove ccp(4)
> >   from i386.
> 
> You would think that.  The shift instructions on x86 effectively ignore the
> upper bits of the count, so a 33-bit shift on i386 ends up being a 1-bit shift,
> etc. IIRC.

I believe that is Rotate, not shift.


-- 
Rod Grimes                                                 rgrimes@freebsd.org