From owner-freebsd-rc@FreeBSD.ORG Fri Feb 9 00:30:26 2007 Return-Path: X-Original-To: freebsd-rc@hub.freebsd.org Delivered-To: freebsd-rc@hub.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id 9A5A316A400 for ; Fri, 9 Feb 2007 00:30:26 +0000 (UTC) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (freefall.freebsd.org [69.147.83.40]) by mx1.freebsd.org (Postfix) with ESMTP id 8B39813C481 for ; Fri, 9 Feb 2007 00:30:26 +0000 (UTC) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (gnats@localhost [127.0.0.1]) by freefall.freebsd.org (8.13.4/8.13.4) with ESMTP id l190UQYD025112 for ; Fri, 9 Feb 2007 00:30:26 GMT (envelope-from gnats@freefall.freebsd.org) Received: (from gnats@localhost) by freefall.freebsd.org (8.13.4/8.13.4/Submit) id l190UQa9025111; Fri, 9 Feb 2007 00:30:26 GMT (envelope-from gnats) Date: Fri, 9 Feb 2007 00:30:26 GMT Message-Id: <200702090030.l190UQa9025111@freefall.freebsd.org> To: freebsd-rc@FreeBSD.org From: Florent Thoumie Cc: Subject: Re: conf/104884: Add support EtherChannel configuration to rc.conf X-BeenThere: freebsd-rc@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: Florent Thoumie List-Id: "Discussion related to /etc/rc.d design and implementation." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 09 Feb 2007 00:30:26 -0000 The following reply was made to PR conf/104884; it has been noted by GNATS. From: Florent Thoumie To: Doug Barton Cc: Brooks Davis , Norikatsu Shigemura , freebsd-bugs@FreeBSD.org, FreeBSD-gnats-submit@FreeBSD.org, freebsd-rc@FreeBSD.org Subject: Re: conf/104884: Add support EtherChannel configuration to rc.conf Date: Fri, 09 Feb 2007 00:18:17 +0000 This is an OpenPGP/MIME signed message (RFC 2440 and 3156) --------------enig59D108A34FC56C76D5FE6DA7 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable Doug Barton wrote: > Brooks Davis wrote: >> On Thu, Feb 08, 2007 at 11:48:04PM +0000, Florent Thoumie wrote: >>> Brooks Davis wrote: >>>> On Thu, Feb 08, 2007 at 11:30:41PM +0000, Florent Thoumie wrote: >>>>> Brooks Davis wrote: >>>>>> On Thu, Feb 08, 2007 at 01:55:16PM -0800, Doug Barton wrote: >>>>>>> Brooks Davis wrote: >>>>>>> >>>>>>>> The default should be an empty list which results in nothing hap= pening. >>>>>>>> I'd suggest making empty list the value for the default gif_inte= rfaces >>>>>>>> in /etc/defaults/rc.conf in both branches, removing support for = NO in >>>>>>>> CURRENT and emitting a warning in stable. >>>>>>> How about issuing a warning for NO in both branches? Whether I ag= ree >>>>>>> with you or not on the importance of keeping things clean and >>>>>>> consistent, I definitely do not want to err on the side of pedant= ry >>>>>>> over usability. >>>>>> That would be fine. I don't really care as long as it's deprecate= d. >>>>>> >>>>>> FWIW, only users who don't update /etc/defaults/rc.conf or who man= ually >>>>>> set gif_interfaces=3D"NO" would be effected so the size of the set= of >>>>>> effected users is probalby close to epilon and even all that will = happen >>>>>> is cloning an extra interface and then not configuring it so it sh= ould >>>>>> be basicly harmless to just remove direct support for it. >>>>> Fine with me as well. Should we make it a warning on RELENG_6 and a= n >>>>> error on HEAD, or a warning on both. The former being be what I was= >>>>> planning to do, ie. remove support for "NO" in HEAD but issue a mes= sage >>>>> saying semantics have changed. The latter would mean identical code= in >>>>> both HEAD and RELENG_6 (so "NO"-compatibility in both branches), bu= t >>>>> we'd need a reminder to remove this "NO"-support in HEAD once RELEN= G_7 >>>>> is branched. >>>> I'd say a warning in both. >>> Re-reading Doug's message, he's probably thinking the same thing, but= >>> this is for gif_interfaces only, right? >> That's what I'd do. There's no reason to introduce support for an >> instantly deprecated feature in a new variable, particularly since >> gif_interfaces is the odd one out. >=20 > Yes. Here's the updated network.subr diff: http://people.freebsd.org/~flz/local/netsubr.diff --=20 Florent Thoumie flz@FreeBSD.org FreeBSD Committer --------------enig59D108A34FC56C76D5FE6DA7 Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.5 (FreeBSD) Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org iD8DBQFFy73OMxEkbVFH3PQRCrb0AJ93RAfQtJBEaN+vnZYfNX9ZITYvTgCfQ9FQ 68/45jWOhtBJHWxpAsleAmE= =ArTm -----END PGP SIGNATURE----- --------------enig59D108A34FC56C76D5FE6DA7--