From owner-freebsd-bugs@freebsd.org  Wed Jun 29 07:38:29 2016
Return-Path: <owner-freebsd-bugs@freebsd.org>
Delivered-To: freebsd-bugs@mailman.ysv.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org
 [IPv6:2001:1900:2254:206a::19:1])
 by mailman.ysv.freebsd.org (Postfix) with ESMTP id 8DF73B864DD
 for <freebsd-bugs@mailman.ysv.freebsd.org>;
 Wed, 29 Jun 2016 07:38:29 +0000 (UTC)
 (envelope-from bugzilla-noreply@freebsd.org)
Received: from kenobi.freebsd.org (kenobi.freebsd.org
 [IPv6:2001:1900:2254:206a::16:76])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (Client did not present a certificate)
 by mx1.freebsd.org (Postfix) with ESMTPS id 74C792D42
 for <freebsd-bugs@FreeBSD.org>; Wed, 29 Jun 2016 07:38:29 +0000 (UTC)
 (envelope-from bugzilla-noreply@freebsd.org)
Received: from bugs.freebsd.org ([127.0.1.118])
 by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id u5T7cTRU039843
 for <freebsd-bugs@FreeBSD.org>; Wed, 29 Jun 2016 07:38:29 GMT
 (envelope-from bugzilla-noreply@freebsd.org)
From: bugzilla-noreply@freebsd.org
To: freebsd-bugs@FreeBSD.org
Subject: [Bug 210686] NCQ_TRIM_BROKEN quirk mismatch
Date: Wed, 29 Jun 2016 07:38:29 +0000
X-Bugzilla-Reason: AssignedTo
X-Bugzilla-Type: new
X-Bugzilla-Watch-Reason: None
X-Bugzilla-Product: Base System
X-Bugzilla-Component: kern
X-Bugzilla-Version: 11.0-CURRENT
X-Bugzilla-Keywords: 
X-Bugzilla-Severity: Affects Some People
X-Bugzilla-Who: allg@ayatan.org
X-Bugzilla-Status: New
X-Bugzilla-Resolution: 
X-Bugzilla-Priority: ---
X-Bugzilla-Assigned-To: freebsd-bugs@FreeBSD.org
X-Bugzilla-Flags: 
X-Bugzilla-Changed-Fields: bug_id short_desc product version rep_platform
 op_sys bug_status bug_severity priority component assigned_to reporter
 attachments.created
Message-ID: <bug-210686-8@https.bugs.freebsd.org/bugzilla/>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/
Auto-Submitted: auto-generated
MIME-Version: 1.0
X-BeenThere: freebsd-bugs@freebsd.org
X-Mailman-Version: 2.1.22
Precedence: list
List-Id: Bug reports <freebsd-bugs.freebsd.org>
List-Unsubscribe: <https://lists.freebsd.org/mailman/options/freebsd-bugs>,
 <mailto:freebsd-bugs-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-bugs/>
List-Post: <mailto:freebsd-bugs@freebsd.org>
List-Help: <mailto:freebsd-bugs-request@freebsd.org?subject=help>
List-Subscribe: <https://lists.freebsd.org/mailman/listinfo/freebsd-bugs>,
 <mailto:freebsd-bugs-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Wed, 29 Jun 2016 07:38:29 -0000

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D210686

            Bug ID: 210686
           Summary: NCQ_TRIM_BROKEN quirk mismatch
           Product: Base System
           Version: 11.0-CURRENT
          Hardware: Any
                OS: Any
            Status: New
          Severity: Affects Some People
          Priority: ---
         Component: kern
          Assignee: freebsd-bugs@FreeBSD.org
          Reporter: allg@ayatan.org

Created attachment 171939
  --> https://bugs.freebsd.org/bugzilla/attachment.cgi?id=3D171939&action=
=3Dedit
patch for ata_da.c

Crucial MX200 is not blacklisted, but NCQ_TRIM_BROKEN quirk is enabled.

> ada0 at ahcich0 bus 0 scbus0 target 0 lun 0
> ada0: <Crucial CT250MX200SSD3 MU03> ACS-3 ATA SATA 3.x device
> ada0: Serial Number xx
> ada0: 600.000MB/s transfers (SATA 3.x, UDMA6, PIO 8192bytes)
> ada0: Command Queueing enabled
> ada0: 238475MB (488397168 512 byte sectors)
> ada0: quirks=3D0x2<NCQ_TRIM_BROKEN>

Mismatched quirk entry is:

> 		/*
> 		 * Crucial M500 SSDs all other firmware
> 		 * NCQ Trim doesn't work
> 		 */
> 		{ T_DIRECT, SIP_MEDIA_FIXED, "*", "Crucial CT*M500*", "*" },
> 		/*quirks*/ADA_Q_NCQ_TRIM_BROKEN

"Crucial CT*M500*" is equivalent to "Crucial CT*".
(wildcard '*' in pattern matches rest of name (in cam.c))

I wrote a patch. This patch also includes fix for Micron M510/M550.

--=20
You are receiving this mail because:
You are the assignee for the bug.=