Date: Tue, 23 Dec 2008 11:46:44 -0800 (PST) From: Doug Barton <dougb@FreeBSD.org> To: Alfred Perlstein <alfred@freebsd.org> Cc: net@freebsd.org Subject: Re: ipv6 bugfix, need review. Message-ID: <alpine.BSF.2.00.0812231145340.1179@ync.qbhto.arg> In-Reply-To: <20081223001216.GH18389@elvis.mu.org> References: <20081223001216.GH18389@elvis.mu.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Mon, 22 Dec 2008, Alfred Perlstein wrote:
> Hey guys, we found a bug at Juniper and it resolves an issue
> for us. I've been asked to forward this to FreeBSD, I honestly
> am not that clear on the issue so I'm hoping someone can step
> up to review this.
>
> Synopsis is:
>
> The traffic class byte is set to 0x00000000 in the header of some
> BGP packets sent between interfaces that have IPv6 addresses,
> instead of the correct setting 0xc0 (INTERNETCONTROL).
>
> Fix is small and attached. One thing I am wondering, do we
> need to check "if (inp)" ? I don't think so.
How about adding an assert to the patch to prove this theory? :)
I'll test it on my home box (which has IPv6) as soon as I'm done with the
stuff I'm working on atm.
hth,
Doug
--
This .signature sanitized for your protection
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?alpine.BSF.2.00.0812231145340.1179>