From owner-svn-src-head@freebsd.org Thu Feb 22 16:24:23 2018 Return-Path: Delivered-To: svn-src-head@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 80639F13CBA for ; Thu, 22 Feb 2018 16:24:23 +0000 (UTC) (envelope-from wlosh@bsdimp.com) Received: from mail-it0-x231.google.com (mail-it0-x231.google.com [IPv6:2607:f8b0:4001:c0b::231]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 0CFF16BB91 for ; Thu, 22 Feb 2018 16:24:23 +0000 (UTC) (envelope-from wlosh@bsdimp.com) Received: by mail-it0-x231.google.com with SMTP id p204so6846680itc.4 for ; Thu, 22 Feb 2018 08:24:23 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bsdimp-com.20150623.gappssmtp.com; s=20150623; h=mime-version:sender:in-reply-to:references:from:date:message-id :subject:to:cc; bh=lTs/xv0I+XBLwDLyrkXcJX9A7HilAUJbeLy+dnvbyKc=; b=mTvQDo1Q9+2e3PuNqgjjXoqV4S+RRLQ8KcNdJlwYOKNW0CyypOUZTMwANzbFgpeGOX UHAKedaEwWWSIbHEj7WWp5Hkh61LE6cA06e/7j7ueW0pdX1aTN0HtzdXYAS/Q8/WWQLV gHOlE++JPakmVu2KtI1a8T14NdTRX27H6U9aVKekUA96GT3CMnCgCa8UT+NVZrtkY8XM t3IfcK3R01/ypX5xEB8VKl3hrPu0lMvKer9Vrr+8QQ8KeXzYUP22o/OdXuXukB/+Vcq/ 3QO8xAtVL8SfiUKRAGxonfMc2XaCYxJQdjcFOqDZaa0KPbKFFxmzdsCWieEiLgSKhYMt cV4g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:sender:in-reply-to:references:from :date:message-id:subject:to:cc; bh=lTs/xv0I+XBLwDLyrkXcJX9A7HilAUJbeLy+dnvbyKc=; b=byPXM3VhIbwgEis3UZbb0XB3UZGfq+yFEqNIh9v6pZe32QaQTjLNWKecLPtE+ElRE+ Dc5O4Fy0OsQLhU9G5jfitwu5NQwkRvZ1hW9GuEvEy1fDHZw11kNmAZ5W0ogOt9GOPZDS WioDc0JFEOk5QrTP0PhKiEwrtKJ6FTlXtWFAn2fnpdAVIDAna2CIv/bI+FPhdc4e6un5 1p5A5qNoqyJ7fOuaMtZFaQ2vDj0+3BNH809Edux8FaImFLH4YjRgRhR6n3VB+aQNG+tm QBCWJaWZrGwpH0/wgMhv/SAq+b74So/X4Uewe9Yfr8OeAmZvu+BWriTo3BdPQbjRjSar qzEA== X-Gm-Message-State: APf1xPBhC7bcgetrtfYA3EeD9FSWI0V65516JS8IAsWnwz7vuky9ZECM 0e9ceIO7XzaIm7wJcnvEY+F0eEAgWyvYK5TlYoAVHA== X-Google-Smtp-Source: AH8x226xtwB5WxS44SpObtLVaO2iPL1QeVx1bTvb8S8T+G2bHjz3WAUiLhirE3KOAwzKX8MswHl/kECoSjMVwiIBB7A= X-Received: by 10.36.111.4 with SMTP id x4mr8985044itb.51.1519316662215; Thu, 22 Feb 2018 08:24:22 -0800 (PST) MIME-Version: 1.0 Sender: wlosh@bsdimp.com Received: by 10.79.201.67 with HTTP; Thu, 22 Feb 2018 08:24:21 -0800 (PST) X-Originating-IP: [50.253.99.174] In-Reply-To: References: <201802221332.w1MDWVao004564@repo.freebsd.org> From: Warner Losh Date: Thu, 22 Feb 2018 09:24:21 -0700 X-Google-Sender-Auth: HLIOyHxZCiUbMINBjPSGEpbkzfc Message-ID: Subject: Re: svn commit: r329824 - in head: sbin/nvmecontrol sys/cam/nvme sys/conf sys/dev/mpr sys/dev/nvme To: Kyle Evans Cc: Alan Somers , Wojciech Macek , svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers Content-Type: text/plain; charset="UTF-8" X-Content-Filtered-By: Mailman/MimeDel 2.1.25 X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.25 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 22 Feb 2018 16:24:23 -0000 On Thu, Feb 22, 2018 at 9:20 AM, Kyle Evans wrote: > On Thu, Feb 22, 2018 at 10:19 AM, Alan Somers wrote: > > On Thu, Feb 22, 2018 at 6:32 AM, Wojciech Macek wrote: > > > >> Author: wma > >> Date: Thu Feb 22 13:32:31 2018 > >> New Revision: 329824 > >> URL: https://svnweb.freebsd.org/changeset/base/329824 > >> > >> Log: > >> NVMe: Add big-endian support > >> > >> Remove bitfields from defined structures as they are not portable. > >> Instead use shift and mask macros in the driver and nvmecontrol > >> application. > >> > >> NVMe is now working on powerpc64 host. > >> > >> Submitted by: Michal Stanek > >> Obtained from: Semihalf > >> Reviewed by: imp, wma > >> Sponsored by: IBM, QCM Technologies > >> Differential revision: https://reviews.freebsd.org/D13916 > >> > > > > It looks like this change broke the build with Clang: > > > > Fixed in r329827... all little endian arch's broken, not so great. =( > At least the kernel is passing my tests this morning... I didn't think this was ready and hasn't yet lifted my objections in the review... Not sure I want to get grumpy about it yet, but I'm not pleased to see this. Warner