Date: Mon, 02 Feb 2004 08:14:18 +0300 From: Sergey Matveychuk <sem@ciam.ru> To: Pav Lucistnik <pav@FreeBSD.org> Cc: freebsd-ports-bugs@FreeBSD.org Subject: Re: ports/62104: [MAINTAINER] ftp/frox: Utilize OPTIONS Message-ID: <401DDCAA.6030302@ciam.ru> In-Reply-To: <200402011900.i11J0URE006907@freefall.freebsd.org> References: <200402011900.i11J0URE006907@freefall.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
This is a multi-part message in MIME format.
--------------040004050902000308060100
Content-Type: text/plain; charset=us-ascii; format=flowed
Content-Transfer-Encoding: 7bit
Pav Lucistnik wrote:
> Synopsis: [MAINTAINER] ftp/frox: Utilize OPTIONS
>
> State-Changed-From-To: open->feedback
> State-Changed-By: pav
> State-Changed-When: Sun Feb 1 10:59:50 PST 2004
> State-Changed-Why:
> This will not work, because you still use RUN_* and WITHOUT_*
> in the Makefile, but OPTIONS will only produce WITH_*,
> like WITH_AS_ROOT ... you have to adjust the rest of the Makefile.
I agree with RUN_AS_ROOT. I've missed it. Here is a new patch.
But OPTIONS works fine with both WITH_* and WITHOUT_* variables.
---
Sem.
--------------040004050902000308060100
Content-Type: text/plain;
name="frox-0.7.12.patch"
Content-Transfer-Encoding: 7bit
Content-Disposition: inline;
filename="frox-0.7.12.patch"
--- Makefile.orig Tue Jan 27 00:52:52 2004
+++ Makefile Mon Feb 2 08:09:31 2004
@@ -2,7 +2,7 @@
# Date created: 11 June 2002
# Whom: Sergey Matveychuk <sem@ciam.ru>
#
-# $FreeBSD: ports/ftp/frox/Makefile,v 1.10 2004/01/26 21:52:52 sergei Exp $
+# $FreeBSD: ports/ftp/frox/Makefile,v 1.9 2004/01/19 08:16:22 krion Exp $
#
PORTNAME= frox
@@ -56,23 +56,18 @@
.if !defined(WITHOUT_CCP)
CONFIGURE_ARGS+= --enable-ccp
.endif
-.if defined(RUN_AS_ROOT)
+.if defined(WITH_ROOT_RUN)
CONFIGURE_ARGS+= --enable-run-as-root
.endif
-pre-fetch:
- @${ECHO_MSG} ""
- @${ECHO_MSG} "You can use the following build options:"
- @${ECHO_MSG}
- @${ECHO_MSG} " WITH_IPFILTER=yes use ipfilter instead of ipfw;"
- @${ECHO_MSG} " WITH_VIRUS_SCAN=yes enable to run external virus scaner on each"
- @${ECHO_MSG} " download (experimental);"
- @${ECHO_MSG} " WITHOUT_HTTP_CACHE=yes disable use of external cache;"
- @${ECHO_MSG} " WITHOUT_LOCAL_CACHE=yes disable use of local cache;"
- @${ECHO_MSG} " WITHOUT_CCP=yes disable ftp-proxy style command control programs;"
- @${ECHO_MSG} " RUN_AS_ROOT=yes allow frox running as root for using"
- @${ECHO_MSG} " port number <1024 (not recomended)."
- @${ECHO_MSG} ""
+.include <bsd.port.pre.mk>
+
+OPTIONS= IPFILTER "Use ipfilter instead of ipfw" off \
+ VIRUS_SCAN "Run external virus scaner on each download" off \
+ HTTP_CACHE "Enable use of external cache" on \
+ LOCAL_CACHE "Enable use of local cache" off \
+ CCP "Ftp-proxy style command control programs" on \
+ ROOT_RUN "Allow frox running as root (not recomended)" off
pre-patch:
@${SED} ${SED_SCRIPT} ${PKGDIR}/pkg-message >${PKGMESSAGE}
@@ -96,4 +91,4 @@
${INSTALL_SCRIPT} -m 751 ${WRKDIR}/frox.sh ${RC_DIR}/frox${RC_SUFX}; \
${CAT} ${PKGMESSAGE}
-.include <bsd.port.mk>
+.include <bsd.port.post.mk>
--------------040004050902000308060100--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?401DDCAA.6030302>