From owner-cvs-all Fri May 17 13: 1:23 2002 Delivered-To: cvs-all@freebsd.org Received: from Awfulhak.org (gw.Awfulhak.org [217.204.245.18]) by hub.freebsd.org (Postfix) with ESMTP id 2A82B37B416; Fri, 17 May 2002 13:01:09 -0700 (PDT) Received: from hak.lan.Awfulhak.org (root@hak.lan.Awfulhak.org [IPv6:fec0::1:12]) by Awfulhak.org (8.12.3/8.12.3) with ESMTP id g4HK15va091178; Fri, 17 May 2002 21:01:06 +0100 (BST) (envelope-from brian@Awfulhak.org) Received: from hak.lan.Awfulhak.org (brian@localhost [127.0.0.1]) by hak.lan.Awfulhak.org (8.12.3/8.12.3) with ESMTP id g4HK15Ws096383; Fri, 17 May 2002 21:01:05 +0100 (BST) (envelope-from brian@hak.lan.Awfulhak.org) Message-Id: <200205172001.g4HK15Ws096383@hak.lan.Awfulhak.org> X-Mailer: exmh version 2.5 07/13/2001 with nmh-1.0.4 To: Alfred Perlstein Cc: Brian Somers , cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/usr.sbin/sysinstall index.c In-Reply-To: Message from Alfred Perlstein of "Fri, 17 May 2002 08:32:46 PDT." <20020517153246.GJ20683@elvis.mu.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Date: Fri, 17 May 2002 21:01:05 +0100 From: Brian Somers Sender: owner-cvs-all@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG > * Brian Somers [020517 02:49] wrote: > > brian 2002/05/17 02:46:47 PDT > > > > Modified files: > > usr.sbin/sysinstall index.c > > Log: > > MFS: Extend a buffer size so that packages with particularily deep dependency > > lists install properly. > > > > Revision Changes Path > > 1.97 +1 -1 src/usr.sbin/sysinstall/index.c > > Why not use asprintf or something? This code could use a bit of an > overhaul, not another bandaid. :( Well, I followed up to re@ that I'm going to commit to removing some of the buffer limitations & overflows in -current and MFC after the release - but I guess you've exposed my patch as a bandaid... Grrr. > -- > -Alfred Perlstein [alfred@freebsd.org] > 'Instead of asking why a piece of software is using "1970s technology," > start asking why software is ignoring 30 years of accumulated wisdom.' > Tax deductible donations for FreeBSD: http://www.freebsdfoundation.org/ -- Brian Don't _EVER_ lose your sense of humour ! To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message