From owner-svn-src-all@freebsd.org Sun Jul 24 04:39:06 2016 Return-Path: Delivered-To: svn-src-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id E514DBA071B; Sun, 24 Jul 2016 04:39:06 +0000 (UTC) (envelope-from peter@wemm.org) Received: from smtp2.wemm.org (smtp2.wemm.org [192.203.228.78]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client CN "smtp2.wemm.org", Issuer "Let's Encrypt Authority X3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id C69D61355; Sun, 24 Jul 2016 04:39:06 +0000 (UTC) (envelope-from peter@wemm.org) Received: from overcee.wemm.org (canning.wemm.org [192.203.228.65]) by smtp2.wemm.org (Postfix) with ESMTP id 711F5CBB; Sat, 23 Jul 2016 21:39:05 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=wemm.org; s=m20140428; t=1469335145; bh=fTJvrAD+E0CJEMJWktmXhRtAINLO/w6noqTE01hSHlA=; h=From:To:Cc:Subject:Date:In-Reply-To:References; b=dL9tlYkKba13XfqOPVe88v5GviiTCunMOkStMfrpnP06LDnCuVFsPj0pFQ/VFHT1d tdHSqfYdwmfqV3g9ecM8aebM+yuskUuDAcuLDQ7JAEdGlrVXooaOqnVJdUL2WvDSKt u8/BsNkbItSP1/hTJFKdt3T95qIcNRI8aNUQkrEs= From: Peter Wemm To: svn-src-head@freebsd.org Cc: "Andrey V. Elsukov" , src-committers@freebsd.org, svn-src-all@freebsd.org, "re@freebsd.org" Subject: Re: svn commit: r303019 - head/sys/geom Date: Sat, 23 Jul 2016 21:39 -0700 Message-ID: <3277576.dFZ2EGo2Fh@overcee.wemm.org> User-Agent: KMail/4.14.3 (FreeBSD/11.0-ALPHA6; KDE/4.14.3; amd64; ; ) In-Reply-To: <201607190536.u6J5aLl7015268@repo.freebsd.org> References: <201607190536.u6J5aLl7015268@repo.freebsd.org> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="nextPart4542475.Ev8TQeSbU3"; micalg="pgp-sha256"; protocol="application/pgp-signature" X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.22 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 24 Jul 2016 04:39:07 -0000 --nextPart4542475.Ev8TQeSbU3 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="us-ascii" On Tuesday, July 19, 2016 05:36:21 AM Andrey V. Elsukov wrote: > Author: ae > Date: Tue Jul 19 05:36:21 2016 > New Revision: 303019 > URL: https://svnweb.freebsd.org/changeset/base/303019 >=20 > Log: > Use g_resize_provider() to change the size of GEOM_DISK provider, > when it is being opened. This should fix the possible loss of a res= ize > event when disk capacity changed. Are you sure about this? We have machines in the freebsd.org cluster t= hat now=20 panic on boot: Trying to mount root from zfs:zroot []... GEOM_PART: da0 was automatically resized. Use `gpart commit da0` to save changes or `gpart undo da0` to revert = them. GEOM_PART: integrity check failed (da0, GPT) Fatal trap 12: page fault while in kernel mode cpuid =3D 1; apic id =3D 01 fault virtual address=09=3D 0x48 fault code=09=09=3D supervisor read data, page not present instruction pointer=09=3D 0x20:0xffffffff80740005 stack pointer=09 =3D 0x28:0xfffffe01f119db10 frame pointer=09 =3D 0x28:0xfffffe01f119db30 code segment=09=09=3D base 0x0, limit 0xfffff, type 0x1b =09=09=09=3D DPL 0, pres 1, long 1, def32 0, gran 1 processor eflags=09=3D interrupt enabled, resume, IOPL =3D 0 current process=09=09=3D 13 (g_event) [ thread pid 13 tid 100019 ] Stopped at g_part_resize+0x35: testb $0x8,0x48(%rbx) db> where Tracing pid 13 tid 100019 td 0xfffff8000426fa00 g_part_resize() at g_part_resize+0x35/frame 0xfffffe01f119db30 g_resize_provider_event() at g_resize_provider_event+0xb5/frame 0xfffff= e01f119d0 g_run_events() at g_run_events+0x20e/frame 0xfffffe01f119dbb0 .. It is exploding here: g_part_resize(struct g_consumer *cp) { struct g_part_table *table; G_PART_TRACE((G_T_TOPOLOGY, "%s(%s)", __func__, cp->provider->n= ame)); g_topology_assert(); table =3D cp->geom->softc; if (table->gpt_opened =3D=3D 0) { ^^^^^^^^^ (table is null) Are you creating events too soon now? At the very least, please reconsider having this MFC'ed without getting= to the=20 bottom of it. =2D-=20 Peter Wemm - peter@wemm.org; peter@FreeBSD.org; peter@yahoo-inc.com; KI= 6FJV UTF-8: for when a ' or ... just won\342\200\231t do\342\200\246 --nextPart4542475.Ev8TQeSbU3 Content-Type: application/pgp-signature; name="signature.asc" Content-Description: This is a digitally signed message part. Content-Transfer-Encoding: 7Bit -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQEcBAABCAAGBQJXlEZkAAoJEDXWlwnsgJ4EnC0IAK/3ZRLGACt3gTAWLETbIcJe LGiZw4R9UlNZmbhh49q7wXOIfrlgRFyCh13HSm34CyEFglbE6RMAMiDcMaLNO6LD XIqWJ2gmQxiOU8tdcXign4QxWnO1G7gycZDOnwIRzULsqi2cUmXP9zUomlXoBA08 rtMmHJo+vb9CbUNfu92P+aw/XydAN3CLIwLSHKl52wF4wvEgwv8AP34VWf3fjBWp weLMsslc43EjvCSchDZpf+eFWvBtH35r5aUm3Aty2agnUkhpnnKBkJ2eP7gMl2G3 30qAZZS8m+NGz0FR/RHVpYXgj7UhmuNWUjMXkLq1FX4Oy7/3m0MRKTrKEAhZb8g= =48mN -----END PGP SIGNATURE----- --nextPart4542475.Ev8TQeSbU3--