From owner-freebsd-hackers Tue Aug 21 0:10:32 2001 Delivered-To: freebsd-hackers@freebsd.org Received: from critter.freebsd.dk (critter.freebsd.dk [212.242.86.163]) by hub.freebsd.org (Postfix) with ESMTP id C927537B40B; Tue, 21 Aug 2001 00:10:27 -0700 (PDT) (envelope-from phk@critter.freebsd.dk) Received: from critter (localhost [127.0.0.1]) by critter.freebsd.dk (8.11.4/8.11.4) with ESMTP id f7L7AOn13309; Tue, 21 Aug 2001 09:10:25 +0200 (CEST) (envelope-from phk@critter.freebsd.dk) To: obrien@FreeBSD.ORG Cc: hackers@FreeBSD.ORG Subject: Re: header polution In-Reply-To: Your message of "Mon, 20 Aug 2001 17:57:43 PDT." <20010820175743.A33795@dragon.nuxi.com> Date: Tue, 21 Aug 2001 09:10:24 +0200 Message-ID: <13307.998377824@critter> From: Poul-Henning Kamp Sender: owner-freebsd-hackers@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG In message <20010820175743.A33795@dragon.nuxi.com>, "David O'Brien" writes: >When compiling the `dict' port, one gets: > > In file included from /usr/include/machine/signal.h:54, > from /usr/include/sys/signal.h:178, > from /usr/include/signal.h:44, > from dict.h:33, > from clientparse.y:25: > /usr/include/machine/trap.h:105: warning: `T_USER' redefined > >This seems very wrong. Can't we rename "T_USER" in the kernel to >"_T_USER", or wrap it in _KERNEL? The comment in machine/signal.h(x86) >says: > > #include /* codes for SIGILL, SIGFPE */ > >but does that mean we must expose the entire contents of trap.h to >userland? The problem is T_ is very common in lex source. We most certainly shouldn't. Everything but the needed bits should be #ifdef KERNEL. -- Poul-Henning Kamp | UNIX since Zilog Zeus 3.20 phk@FreeBSD.ORG | TCP/IP since RFC 956 FreeBSD committer | BSD since 4.3-tahoe Never attribute to malice what can adequately be explained by incompetence. To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-hackers" in the body of the message