From owner-svn-src-all@FreeBSD.ORG Thu Mar 4 19:14:13 2010 Return-Path: Delivered-To: svn-src-all@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id CC874106566C; Thu, 4 Mar 2010 19:14:13 +0000 (UTC) (envelope-from scottl@samsco.org) Received: from pooker.samsco.org (pooker.samsco.org [168.103.85.57]) by mx1.freebsd.org (Postfix) with ESMTP id 6907A8FC22; Thu, 4 Mar 2010 19:14:13 +0000 (UTC) Received: from [IPv6:::1] (pooker.samsco.org [168.103.85.57]) by pooker.samsco.org (8.14.2/8.14.2) with ESMTP id o24JE7JL003572; Thu, 4 Mar 2010 12:14:07 -0700 (MST) (envelope-from scottl@samsco.org) Mime-Version: 1.0 (Apple Message framework v1077) Content-Type: text/plain; charset=us-ascii From: Scott Long In-Reply-To: <20100304.115305.769599705400649806.imp@bsdimp.com> Date: Thu, 4 Mar 2010 12:14:07 -0700 Content-Transfer-Encoding: quoted-printable Message-Id: References: <20100304.105304.29649700129034.imp@bsdimp.com> <9A8644AD-3B92-4BCE-8A51-132F8EA35F7D@samsco.org> <20100304.115305.769599705400649806.imp@bsdimp.com> To: "M. Warner Losh" X-Mailer: Apple Mail (2.1077) X-Spam-Status: No, score=-4.6 required=3.8 tests=ALL_TRUSTED,AWL,BAYES_00 autolearn=ham version=3.1.8 X-Spam-Checker-Version: SpamAssassin 3.1.8 (2007-02-13) on pooker.samsco.org Cc: svn-src-head@FreeBSD.org, svn-src-all@FreeBSD.org, src-committers@FreeBSD.org, ed@FreeBSD.org Subject: Re: svn commit: r194266 - head/usr.bin/chpass X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 04 Mar 2010 19:14:13 -0000 On Mar 4, 2010, at 11:53 AM, M. Warner Losh wrote: > In message: <9A8644AD-3B92-4BCE-8A51-132F8EA35F7D@samsco.org> > Scott Long writes: > : On Mar 4, 2010, at 10:53 AM, M. Warner Losh wrote: > : >=20 > : > In message: > : > Scott Long writes: > : > : Forcing the entire build to fail if chflags fails breaks = installing > : > : to an NFS destination. I haven't tested all possible = permutations > : > : of src vs dest filesystems mounting, but I don't see how it can > : > : work over any type of NFS mount. What is the reason for forcing > : > : this failure? The NO_FSCHG variable is undocumented, and the > : > : failure mode here is pretty useless at helping the user fix the > : > : problem. I'd like to re-add the '-' modifier to the chflags > : > : command that you removed. > : >=20 > : > NO_FSCHG variable has been around a long time, and is de-facto > : > supported. It will be documented shortly when I get done cleaning = up > : > build(7). > : >=20 > : > NO_FSCHG has been the documented way (in examples) for installing = over > : > NFS for a very long time. It looks to my eye like this change = fixed a > : > problem with that... > : >=20 > : > Warner > : >=20 > : > :=20 > :=20 > : Every other base package that sets schg does so by allowing chflags = to silently fail. My change puts chpass back into conformance with the = status quo. >=20 > Well, maybe for chflags, but not for install. You still need NO_FSCHG > if you are installing over NFS, with or without this change... >=20 What am I missing by not using it? Just a few minutes ago I did a = successful install over NFS on 9-current and 7-stable. Scott