From owner-svn-src-stable@FreeBSD.ORG Fri Apr 17 16:50:42 2009 Return-Path: Delivered-To: svn-src-stable@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 264101065692; Fri, 17 Apr 2009 16:50:42 +0000 (UTC) (envelope-from alc@cs.rice.edu) Received: from mail.cs.rice.edu (mail.cs.rice.edu [128.42.1.31]) by mx1.freebsd.org (Postfix) with ESMTP id F21008FC23; Fri, 17 Apr 2009 16:50:41 +0000 (UTC) (envelope-from alc@cs.rice.edu) Received: from mail.cs.rice.edu (localhost.localdomain [127.0.0.1]) by mail.cs.rice.edu (Postfix) with ESMTP id AA7562C2C60; Fri, 17 Apr 2009 11:32:57 -0500 (CDT) X-Virus-Scanned: by amavis-2.4.0 at mail.cs.rice.edu Received: from mail.cs.rice.edu ([127.0.0.1]) by mail.cs.rice.edu (mail.cs.rice.edu [127.0.0.1]) (amavisd-new, port 10024) with LMTP id 1UF3Dswn17ve; Fri, 17 Apr 2009 11:32:50 -0500 (CDT) Received: from adsl-216-63-78-18.dsl.hstntx.swbell.net (adsl-216-63-78-18.dsl.hstntx.swbell.net [216.63.78.18]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by mail.cs.rice.edu (Postfix) with ESMTP id 1BBDD2C2B32; Fri, 17 Apr 2009 11:32:48 -0500 (CDT) Message-ID: <49E8AF2F.1090708@cs.rice.edu> Date: Fri, 17 Apr 2009 11:32:47 -0500 From: Alan Cox User-Agent: Thunderbird 2.0.0.21 (X11/20090404) MIME-Version: 1.0 To: John Baldwin References: <200904171535.n3HFZGoH026439@svn.freebsd.org> <200904171144.51791.jhb@freebsd.org> In-Reply-To: <200904171144.51791.jhb@freebsd.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Cc: Alan Cox , svn-src-stable@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org, svn-src-stable-7@freebsd.org Subject: Re: svn commit: r191204 - in stable/7/sys: . contrib/pf dev/ath/ath_hal dev/cxgb vm X-BeenThere: svn-src-stable@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: SVN commit messages for all the -stable branches of the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 17 Apr 2009 16:50:42 -0000 John Baldwin wrote: > On Friday 17 April 2009 11:35:16 am Alan Cox wrote: > >> Author: alc >> Date: Fri Apr 17 15:35:16 2009 >> New Revision: 191204 >> URL: http://svn.freebsd.org/changeset/base/191204 >> >> Log: >> MFC r175055 >> Defer setting either PG_CACHED or PG_FREE until after the free page >> queues lock is acquired. Otherwise, the state of a reservation's >> pages' flags and its population count can be inconsistent. That could >> result in a page being freed twice. >> >> (This change should have been included in the MFC of the superpages >> support.) >> >> Thanks to: pho for an illuminating crash >> > > Thanks. > > Pointy hat to: jhb > > I think that your bravery to even attempt the MFC absolves you of several pointy hats. I was too chicken. :-) Alan