From owner-cvs-all@FreeBSD.ORG Fri Feb 4 16:05:35 2005 Return-Path: Delivered-To: cvs-all@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id E631D16A4CE; Fri, 4 Feb 2005 16:05:35 +0000 (GMT) Received: from harmony.village.org (rover.village.org [168.103.84.182]) by mx1.FreeBSD.org (Postfix) with ESMTP id 441B843D39; Fri, 4 Feb 2005 16:05:35 +0000 (GMT) (envelope-from imp@bsdimp.com) Received: from localhost (warner@rover2.village.org [10.0.0.1]) by harmony.village.org (8.13.1/8.13.1) with ESMTP id j14G3jCS021425; Fri, 4 Feb 2005 09:03:45 -0700 (MST) (envelope-from imp@bsdimp.com) Date: Fri, 04 Feb 2005 09:05:33 -0700 (MST) Message-Id: <20050204.090533.115913234.imp@bsdimp.com> To: nate@root.org From: "M. Warner Losh" In-Reply-To: <420322CA.3090201@root.org> References: <42031DC4.3000109@root.org> <420322CA.3090201@root.org> X-Mailer: Mew version 3.3 on Emacs 21.3 / Mule 5.0 (SAKAKI) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit cc: cvs-src@FreeBSD.org cc: src-committers@FreeBSD.org cc: cvs-all@FreeBSD.org cc: marcel@xcllnt.net Subject: Re: cvs commit: src/sys/ia64/ia64 machdep.c X-BeenThere: cvs-all@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the entire tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 04 Feb 2005 16:05:36 -0000 In message: <420322CA.3090201@root.org> Nate Lawson writes: : Marcel Moolenaar wrote: : > : > On Feb 3, 2005, at 11:01 PM, Nate Lawson wrote: : > : >> Marcel Moolenaar wrote: : >> : >>> marcel 2005-02-04 06:38:58 UTC : >>> FreeBSD src repository : >>> Modified files: : >>> sys/ia64/ia64 machdep.c Log: : >>> Include sys/bus.h before sys/cpu.h. The latter needs device_t. : >>> Revision Changes Path : >>> 1.195 +1 -0 src/sys/ia64/ia64/machdep.c : >> : >> : >> Thanks, I've made similar changes to the other arches too. : > : > : > No worries. Sorry I didn't had the time to test before committing. : > : > BTW, I still have a link error: : > : > pluto2# make : > linking kernel.debug : > acpi_cpu.o(.text+0x2302): In function `acpi_cpu_startup': : > ../../../dev/acpica/acpi_cpu.c:757: undefined reference to `cpu_devclass' : > acpi_cpu.o(.data+0x1a8): In function `acpi_cpu_probe': : > ./bus_if.h:107: undefined reference to `cpu_devclass' : > *** Error code 1 : > : > Stop in /q/6.x/src/sys/ia64/compile/PLUTO2. : > : > Can it be that you missed a file? : : No, it's something I need to fix one way or the other and had on my todo : list. I'm not sure if my approach is correct -- should different : drivers for the same hardware share the same devclass? I have : legacy::cpu and acpi::cpu sharing the same devclass value since neither : can be attached at the same time. I thought in the past there might be : some advantage to this but can't remember the rationale. In general, we've said that all devices who have the same name must share the same devclass, or you wind up with two devices that could be called 'cpu0' which can either be harmless, or lead to big problems depending on what that device is... Warner