From owner-svn-ports-all@freebsd.org Wed Feb 1 05:25:43 2017 Return-Path: Delivered-To: svn-ports-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id B7916CCD192; Wed, 1 Feb 2017 05:25:43 +0000 (UTC) (envelope-from jbeich@FreeBSD.org) Received: from repo.freebsd.org (repo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:0]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 6DBC7C26; Wed, 1 Feb 2017 05:25:43 +0000 (UTC) (envelope-from jbeich@FreeBSD.org) Received: from repo.freebsd.org ([127.0.1.37]) by repo.freebsd.org (8.15.2/8.15.2) with ESMTP id v115PgJR086941; Wed, 1 Feb 2017 05:25:42 GMT (envelope-from jbeich@FreeBSD.org) Received: (from jbeich@localhost) by repo.freebsd.org (8.15.2/8.15.2/Submit) id v115Pg8L086940; Wed, 1 Feb 2017 05:25:42 GMT (envelope-from jbeich@FreeBSD.org) Message-Id: <201702010525.v115Pg8L086940@repo.freebsd.org> X-Authentication-Warning: repo.freebsd.org: jbeich set sender to jbeich@FreeBSD.org using -f From: Jan Beich Date: Wed, 1 Feb 2017 05:25:42 +0000 (UTC) To: ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org Subject: svn commit: r432971 - head/editors/madedit/files X-SVN-Group: ports-head MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-BeenThere: svn-ports-all@freebsd.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: SVN commit messages for the ports tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 01 Feb 2017 05:25:43 -0000 Author: jbeich Date: Wed Feb 1 05:25:42 2017 New Revision: 432971 URL: https://svnweb.freebsd.org/changeset/ports/432971 Log: editors/madedit: unbreak with clang 4.0 src/MadOptionsDialog.cpp:1179:56: error: ordered comparison between pointer and zero ('const wxChar *' (aka 'const wchar_t *') and 'int') if(g_SelectedCommandItem->cmddata->menuid_name > 0) ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ ^ ~ src/MadOptionsDialog.cpp:1277:42: error: ordered comparison between pointer and zero ('const wxChar *' (aka 'const wchar_t *') and 'int') if(tid->cmddata->menuid_name > 0) ~~~~~~~~~~~~~~~~~~~~~~~~~ ^ ~ PR: 216076 Reported by: antoine (via exp-run) Added: head/editors/madedit/files/patch-src_MadOptionsDialog.cpp (contents, props changed) Added: head/editors/madedit/files/patch-src_MadOptionsDialog.cpp ============================================================================== --- /dev/null 00:00:00 1970 (empty, because file is newly added) +++ head/editors/madedit/files/patch-src_MadOptionsDialog.cpp Wed Feb 1 05:25:42 2017 (r432971) @@ -0,0 +1,20 @@ +--- src/MadOptionsDialog.cpp.orig 2017-02-01 03:37:19 UTC ++++ src/MadOptionsDialog.cpp +@@ -1176,7 +1176,7 @@ void MadOptionsDialog::WxTreeCtrl1SelCha + { + WxListBoxKeys->Set(g_SelectedCommandItem->keys); + wxString hint=wxT('['); +- if(g_SelectedCommandItem->cmddata->menuid_name > 0) ++ if(g_SelectedCommandItem->cmddata->menuid_name) + { + hint+= wxString(g_SelectedCommandItem->cmddata->menuid_name); + } +@@ -1274,7 +1274,7 @@ void MadOptionsDialog::UpdateKeyHint() + g_CommandItemOfNewKey=tid; + wxString cmd; + +- if(tid->cmddata->menuid_name > 0) ++ if(tid->cmddata->menuid_name) + { + cmd+= wxString(tid->cmddata->menuid_name); + }