From owner-freebsd-fs@FreeBSD.ORG Wed Feb 20 09:58:52 2008 Return-Path: Delivered-To: freebsd-fs@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 612D516A403; Wed, 20 Feb 2008 09:58:52 +0000 (UTC) (envelope-from delphij@delphij.net) Received: from tarsier.delphij.net (delphij-pt.tunnel.tserv2.fmt.ipv6.he.net [IPv6:2001:470:1f03:2c9::2]) by mx1.freebsd.org (Postfix) with ESMTP id 349A413C45B; Wed, 20 Feb 2008 09:58:49 +0000 (UTC) (envelope-from delphij@delphij.net) Received: from tarsier.geekcn.org (unknown [202.108.54.204]) (using TLSv1 with cipher ADH-CAMELLIA256-SHA (256/256 bits)) (No client certificate requested) by tarsier.delphij.net (Postfix) with ESMTP id 41DA32844D; Wed, 20 Feb 2008 17:58:48 +0800 (CST) Received: from localhost (unknown [202.108.54.204]) by tarsier.geekcn.org (Postfix) with ESMTP id 0D253EC42E5; Wed, 20 Feb 2008 17:58:48 +0800 (CST) X-Virus-Scanned: amavisd-new at geekcn.org Received: from tarsier.geekcn.org ([202.108.54.204]) by localhost (mail.geekcn.org [202.108.54.204]) (amavisd-new, port 10024) with ESMTP id JDI7nKmHAiIP; Wed, 20 Feb 2008 17:58:43 +0800 (CST) Received: from charlie.delphij.net (c-67-161-39-180.hsd1.ca.comcast.net [67.161.39.180]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by tarsier.geekcn.org (Postfix) with ESMTP id 55B9CEB0B5A; Wed, 20 Feb 2008 17:58:39 +0800 (CST) DomainKey-Signature: a=rsa-sha1; s=default; d=delphij.net; c=nofws; q=dns; h=message-id:date:from:reply-to:organization:user-agent: mime-version:to:cc:subject:references:in-reply-to: x-enigmail-version:openpgp:content-type:content-transfer-encoding; b=hd0if4plfnipRsEqHEt3uSD1l2qoI0K8ALfwIavRtc3CmaeySeO30Uapp+2zmDKh8 VK82Ls8x8t2TRT6EorDHg== Message-ID: <47BBF9CC.4030404@delphij.net> Date: Wed, 20 Feb 2008 01:58:36 -0800 From: Xin LI Organization: The FreeBSD Project User-Agent: Thunderbird 2.0.0.9 (X11/20080122) MIME-Version: 1.0 To: Alexander Leidinger References: <47BBD864.3070905@delphij.net> <20080220105614.eydtkfap4gogk0cw@webmail.leidinger.net> In-Reply-To: <20080220105614.eydtkfap4gogk0cw@webmail.leidinger.net> X-Enigmail-Version: 0.95.5 OpenPGP: id=18EDEBA0; url=http://www.delphij.net/delphij.asc Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Cc: freebsd-fs@freebsd.org, FreeBSD Current , d@delphij.net Subject: Re: [PATCH FOR REVIEW] fsck_ffs: Recover from catastrophic damage X-BeenThere: freebsd-fs@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: d@delphij.net List-Id: Filesystems List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 20 Feb 2008 09:58:52 -0000 -----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 Alexander Leidinger wrote: > Quoting Xin LI (from Tue, 19 Feb 2008 23:36:04 > -0800): > >> Change summary: >> >> fsutil.c: >> - Really update standard superblock. fsck_ffs -b used to update the >> backup superblock which does not recover file systems which have bad >> master superblocks. >> - Instead of coredump, zero out whole cg if its signature is bad. >> >> inode.c: >> - Instead of coredump, zero out whole cg if its signature is bad. > > Does this modify (zero out) on-disk blocks? If yes, shouldn't this ask > for confirmation? My assumption is that if a cylinder group's magic number is damaged, then the whole stuff can not be trusted at all, but yes, I think this should come with a prompt, will add tomorrow. Cheers, - -- Xin LI http://www.delphij.net/ FreeBSD - The Power to Serve! -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.4 (FreeBSD) iD8DBQFHu/nMi+vbBBjt66ARAqN9AJ4zRi6+h0f6R062vQyuEkET32saEACguKSs 4GxuVJdwFt7bIuKlGouO5Dk= =fMnQ -----END PGP SIGNATURE-----