From owner-svn-src-all@freebsd.org Thu May 5 04:18:54 2016 Return-Path: Delivered-To: svn-src-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 13BE3AA3CD8; Thu, 5 May 2016 04:18:54 +0000 (UTC) (envelope-from jhb@freebsd.org) Received: from bigwig.baldwin.cx (bigwig.baldwin.cx [IPv6:2001:470:1f11:75::1]) (using TLSv1 with cipher DHE-RSA-CAMELLIA256-SHA (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id E339D1D49; Thu, 5 May 2016 04:18:53 +0000 (UTC) (envelope-from jhb@freebsd.org) Received: from ralph.baldwin.cx (c-73-231-226-104.hsd1.ca.comcast.net [73.231.226.104]) by bigwig.baldwin.cx (Postfix) with ESMTPSA id EEB1BB987; Thu, 5 May 2016 00:18:52 -0400 (EDT) From: John Baldwin To: Garrett Cooper Cc: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r299108 - head/sys/sys Date: Wed, 04 May 2016 20:17:30 -0700 Message-ID: <2598444.C6bcyDe9AO@ralph.baldwin.cx> User-Agent: KMail/4.14.3 (FreeBSD/10.2-STABLE; KDE/4.14.3; amd64; ; ) In-Reply-To: <201605050251.u452pVSN034598@repo.freebsd.org> References: <201605050251.u452pVSN034598@repo.freebsd.org> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.2.7 (bigwig.baldwin.cx); Thu, 05 May 2016 00:18:53 -0400 (EDT) X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.22 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 05 May 2016 04:18:54 -0000 On Thursday, May 05, 2016 02:51:31 AM Garrett Cooper wrote: > Author: ngie > Date: Thu May 5 02:51:31 2016 > New Revision: 299108 > URL: https://svnweb.freebsd.org/changeset/base/299108 > > Log: > Revert r299096 > > The change broke buildworld when building lib/libkvm > > This change likely needs to be run through a ports -exp run as a sanity > check, as it might break downstream consumers. > > Pointyhat to: adrian > Reported by: kargl (confirmed on $work workstation) > Sponsored by: EMC / Isilon Storage Division 'struct foo *' can be use with a simple forward declare in headers without requiring header pollution (and is often done for that reason). device_t should be used in any .c files, but headers might need to stick with 'struct device *' in a few cases for that reason. I suspect both of these fall into that category. -- John Baldwin