From owner-freebsd-current Tue Feb 23 10:19:12 1999 Delivered-To: freebsd-current@freebsd.org Received: from ns1.yes.no (ns1.yes.no [195.204.136.10]) by hub.freebsd.org (Postfix) with ESMTP id 6912311353 for ; Tue, 23 Feb 1999 10:19:05 -0800 (PST) (envelope-from eivind@bitbox.follo.net) Received: from bitbox.follo.net (bitbox.follo.net [195.204.143.218]) by ns1.yes.no (8.9.1a/8.9.1) with ESMTP id TAA19102; Tue, 23 Feb 1999 19:18:57 +0100 (CET) Received: (from eivind@localhost) by bitbox.follo.net (8.8.8/8.8.6) id TAA11994; Tue, 23 Feb 1999 19:18:57 +0100 (MET) Date: Tue, 23 Feb 1999 19:18:57 +0100 From: Eivind Eklund To: Jos Backus Cc: Dmitrij Tejblum , freebsd-current@FreeBSD.ORG Subject: Re: panic: zone: entry not free Message-ID: <19990223191857.H10845@bitbox.follo.net> References: <19990223094120.A97001@hal.mpn.cp.philips.com> <199902230909.MAA01169@tejblum.dnttm.rssi.ru> <19990223105939.D97001@hal.mpn.cp.philips.com> <19990223161625.B10845@bitbox.follo.net> <19990223170857.A6208@hal.mpn.cp.philips.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Mailer: Mutt 0.95.1i In-Reply-To: <19990223170857.A6208@hal.mpn.cp.philips.com>; from Jos Backus on Tue, Feb 23, 1999 at 05:08:57PM +0100 Sender: owner-freebsd-current@FreeBSD.ORG Precedence: bulk X-Loop: FreeBSD.ORG On Tue, Feb 23, 1999 at 05:08:57PM +0100, Jos Backus wrote: > On Tue, Feb 23, 1999 at 04:16:26PM +0100, Eivind Eklund wrote: > > > Somehow this strikes me as a Bad Thing... > > > > It _is_ a bad thing. I've been pondering what to do with the > > intrusive invariant checks - make them dependent on > > INTRUSIVE_INVARIANTS, perhaps? > > Depends on how dangerous these invariant violations are, I would think. > Iow, do they justify a panic()? IMO, any invariant violation justifies a panic(). Otherwise, people would not pay heed to them. Invariant violations are pretty serious. However, my opinion is also that invariant checks should be non-intrusive - ie, they should not change the normal code path, only add extra checks. A couple of the invariants we have modify the behaviour to make it possible to check for things, and this should be separate from the ones that doesn't modify the behaviour beyond adding checks. Eivind. To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-current" in the body of the message