From owner-svn-src-all@FreeBSD.ORG Mon Feb 2 00:28:27 2015 Return-Path: Delivered-To: svn-src-all@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id 84E22DFE; Mon, 2 Feb 2015 00:28:27 +0000 (UTC) Received: from mail-yk0-x234.google.com (mail-yk0-x234.google.com [IPv6:2607:f8b0:4002:c07::234]) (using TLSv1 with cipher ECDHE-RSA-RC4-SHA (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 40154B5B; Mon, 2 Feb 2015 00:28:27 +0000 (UTC) Received: by mail-yk0-f180.google.com with SMTP id 131so20723446ykp.11; Sun, 01 Feb 2015 16:28:26 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:sender:in-reply-to:references:date:message-id:subject :from:to:cc:content-type; bh=1Z7FteLj26Ne5DLSAZXGzyTrPNP2W9qS1BRCdHkR1XY=; b=O2W2XKp6cuYkhf72z5vpHMUIZvREwbebRfeyVFMWVM7sp2n5LkT1uSp5RQ91pcccik 6CqYAkbAnT989548po2Orn98Prv/GDYLkgealz8jjJ2otG37YxH7+XRI0HKZT6LBqm4x +IA4iXkrSOhGLPeb2sW9ak7MH+LBeBlN7ye1lKz7hD3/Wuxourv4Vnlc41Vz/vE0ZT8Q 2n0sz57ctrCQYAbS2LkQBSN9ZF5O7aB/L7gz0CF0RfdfUBUJgb9BnwMK4bzMN1jK4FCq Hsy0lsKhi7XbNuM72i63i6RBpv7jdq32puUF+tNf0873K19Ur9jJ1KiiX5G0axEyGbcJ gvDQ== MIME-Version: 1.0 X-Received: by 10.170.56.5 with SMTP id 5mr8094939yky.103.1422836906290; Sun, 01 Feb 2015 16:28:26 -0800 (PST) Sender: davide.italiano@gmail.com Received: by 10.170.157.85 with HTTP; Sun, 1 Feb 2015 16:28:26 -0800 (PST) In-Reply-To: <201502020017.t120Hb2g095087@svn.freebsd.org> References: <201502020017.t120Hb2g095087@svn.freebsd.org> Date: Mon, 2 Feb 2015 01:28:26 +0100 X-Google-Sender-Auth: L4s-roTUaC0qxHe3iMBkd_4rWlY Message-ID: Subject: Re: svn commit: r278040 - head/sys/cddl/contrib/opensolaris/uts/common/fs/zfs From: Davide Italiano To: Steven Hartland Content-Type: text/plain; charset=UTF-8 Cc: "svn-src-head@freebsd.org" , "svn-src-all@freebsd.org" , "src-committers@freebsd.org" X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.18-1 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 02 Feb 2015 00:28:27 -0000 On Mon, Feb 2, 2015 at 1:17 AM, Steven Hartland wrote: > Author: smh > Date: Mon Feb 2 00:17:36 2015 > New Revision: 278040 > URL: https://svnweb.freebsd.org/changeset/base/278040 > > Log: > Prevent inlining txg_quiesce > > This allows dtrace to monitor the calls to txg_quiesce which can be really > helpful. > > Also standardise __noinline order for arc_kmem_reap_now. > > Sponsored by: Multiplay > > I found this while I was at iXsystems, trying to port Richard Elling's arc statistics utility to FreeBSD. I do not disagree with the change in theory, but I never committed this because I was worried of performance penalty. Last time I checked Solaris/Illumos actually do not inline this function without any particular directive (I guess this is mostly due to difference in toolchain, in particular in the compiler), so it shouldn't be a big deal, but if you have time, do you mind to check the penalty introduced, if any, is negligible? Thanks, -- Davide "There are no solved problems; there are only problems that are more or less solved" -- Henri Poincare