From owner-svn-src-all@freebsd.org Fri Dec 8 20:10:09 2017 Return-Path: Delivered-To: svn-src-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id E0E19E8DF5F; Fri, 8 Dec 2017 20:10:09 +0000 (UTC) (envelope-from shurd@sasktel.net) Received: from mail16c7.megamailservers.com (mail16c7.megamailservers.com [69.49.98.125]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 6271E2BCE; Fri, 8 Dec 2017 20:10:08 +0000 (UTC) (envelope-from shurd@sasktel.net) Received: from mail16c7.megamailservers.com (localhost [127.0.0.1]) by mail16c7.megamailservers.com (8.14.9/8.13.1) with ESMTP id vB8JohGi024932 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=NO); Fri, 8 Dec 2017 14:50:43 -0500 Received: (from webmail@localhost) by mail16c7.megamailservers.com (8.14.9/8.12.2/Submit) id vB8Joga0024931; Fri, 8 Dec 2017 14:50:42 -0500 Received: from 96-92-42-173-static.hfc.comcastbusiness.net (96-92-42-173-static.hfc.comcastbusiness.net [96.92.42.173]) by webmail.sasktel.net (Webmail 5.0 V.V.I.) with HTTP for ; Fri, 08 Dec 2017 13:50:42 -0600 Message-ID: <20171208135042.aiyw0cs744044wss@webmail.sasktel.net> From: shurd@sasktel.net Reply-to: shurd@sasktel.net To: Stephen Hurd , Ryan Stone Cc: "src-committers@freebsd.org" , "svn-src-all@freebsd.org" , "svn-src-head@freebsd.org" Subject: Re: svn commit: r326702 - head/sys/net Date: Fri, 08 Dec 2017 13:50:42 -0600 X-Priority: 3 X-Authenticated-User: shurd.sasktel.net References: <201712081843.vB8IhVdA064251@repo.freebsd.org> In-Reply-To: MIME-Version: 1.0 User-Agent: Webmail 6.0 X-CTCH-RefID: str=0001.0A020204.5A2AED13.003F, ss=1, re=0.000, recu=0.000, reip=0.000, cl=1, cld=1, fgs=0 X-CTCH-VOD: Unknown X-CTCH-Spam: Unknown X-CTCH-Score: 0.000 X-CTCH-Rules: X-CTCH-Flags: 0 X-CTCH-ScoreCust: 0.000 X-CSC: 0 X-CHA: v=2.2 cv=XbX59Mx5 c=1 sm=1 tr=0 a=WkljmVdYkabdwxfqvArNOQ==:117 a=sKQkgkx3tBUQ55hxqPYCBw==:17 a=v2NWgMxlncYA:10 a=ikZSrtty1KYA:10 a=ocR9PWop10UA:10 a=G-JvYgQUlsIBVzUhMCsA:9 a=6I5d2MoRAAAA:8 a=y7aGmgrOC_-RP0Dl4XUA:9 a=QEXdDO2ut3YA:10 a=pGLkceISAAAA:8 a=OZOGwo4DbkHpDYqCreQA:9 a=MNKL-DSECXe5wbzu:21 a=_W_S_7VecoQA:10 a=IjZwj45LgO3ly-622nXo:22 Content-Type: text/plain; charset=UTF-8; format="flowed" Content-Transfer-Encoding: 7bit Content-Disposition: inline Content-Description: Plaintext Version of Message X-Content-Filtered-By: Mailman/MimeDel 2.1.25 X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.25 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 08 Dec 2017 20:10:10 -0000 On Fri, 8 Dec 2017 13:57:13 -0500, Ryan Stone wrote: On Fri, Dec 8, 2017 at 1:43 PM, Stephen Hurd wrote: > Author: shurd > Date: Fri Dec 8 18:43:31 2017 > New Revision: 326702 > URL: https://svnweb.freebsd.org/changeset/base/326702 > + if (!M_WRITABLE(*m_head)) { > + new_head = m_dup(*m_head, M_NOWAIT); > + if (new_head == NULL) { > + device_printf(dev, "cannot pad short frame, m_dup() failed"); > + return ENOMEM; Don't we leak *m_head here? As far as I can tell the caller doesn't deal with it. Thanks for catching that, fixed in r326706.