From owner-svn-src-user@FreeBSD.ORG Tue Mar 10 22:54:30 2009 Return-Path: Delivered-To: svn-src-user@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 20AD2106568B; Tue, 10 Mar 2009 22:54:30 +0000 (UTC) (envelope-from rwatson@FreeBSD.org) Received: from cyrus.watson.org (cyrus.watson.org [65.122.17.42]) by mx1.freebsd.org (Postfix) with ESMTP id ECC6E8FC1D; Tue, 10 Mar 2009 22:54:29 +0000 (UTC) (envelope-from rwatson@FreeBSD.org) Received: from fledge.watson.org (fledge.watson.org [65.122.17.41]) by cyrus.watson.org (Postfix) with ESMTPS id 8C9E846BA4; Tue, 10 Mar 2009 18:54:29 -0400 (EDT) Date: Tue, 10 Mar 2009 22:54:29 +0000 (GMT) From: Robert Watson X-X-Sender: robert@fledge.watson.org To: Doug Barton In-Reply-To: <49B6DEED.4040902@FreeBSD.org> Message-ID: References: <200903100751.n2A7p02m050724@svn.freebsd.org> <49B6CF13.9060501@FreeBSD.org> <20090310212511.GA53115@onelab2.iet.unipi.it> <49B6DEED.4040902@FreeBSD.org> User-Agent: Alpine 2.00 (BSF 1167 2008-08-23) MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII; format=flowed Cc: Lawrence Stewart , src-committers@freebsd.org, Luigi Rizzo , svn-src-user@freebsd.org Subject: Re: svn commit: r189612 - in user/lstewart/alq_varlen_8.x: sys/kern tools/test/alq X-BeenThere: svn-src-user@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "SVN commit messages for the experimental " user" src tree" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 10 Mar 2009 22:54:31 -0000 On Tue, 10 Mar 2009, Doug Barton wrote: >>> Generally it's preferred not to mix these two types of changes. The >>> preferred course of action is to make the style changes, confirm that the >>> binary is unchanged (e.g., with sha256), then do substantive changes. >>> Makes the revision history a little easier to parse down the road. >> >> well, this is a private branch after all :) > > 1. Good habits come from good practice, and what better place to practice > than in a "private" branch? > > 2. Given that the stuff is in the FreeBSD repository, the presumption is > that it is of some use to the wider FreeBSD community. So IMO community best > practices are a reasonable expectation. Otherwise, why not just keep it > local? Also, if the plan is to use svn merge to pull the changes back from a work branch into the main branch, revision history from that branch will be seen by people tracking the recursive history of changes in the main branch. Robert N M Watson Computer Laboratory University of Cambridge