From nobody Wed Mar 25 15:13:54 2026 X-Original-To: pkgbase@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4fgr6C6lZKz6WPBV; Wed, 25 Mar 2026 15:14:11 +0000 (UTC) (envelope-from pete@nomadlogic.org) Received: from mail.nomadlogic.org (mail.nomadlogic.org [46.21.153.22]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 4fgr6C42Prz3CWj; Wed, 25 Mar 2026 15:14:11 +0000 (UTC) (envelope-from pete@nomadlogic.org) Authentication-Results: mx1.freebsd.org; none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nomadlogic.org; s=04242021; t=1774451644; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=rAUfbsItok6L2UG/rAPaqi30mdHmY2sl9g7m6pur86o=; b=fo/VngLPpVB+Mf3RRL6yjOi/AlI6vgl5XAfbrjA8/vg8cIWQMNhiiZSLlbbZjjO0W6M5Rc +fSPiubFSSrniGsjwBEPCGhhkIfC+KiR3wXA/Xlu/Wf0Mr98VQGW+ZgzkYCiI2ciQ+jdYZ BiN9CdE2w2mTcBqq/S8DLx+3JjNswEc= Received: from smtpclient.apple (47-154-29-181.fdr01.snmn.ca.ip.frontiernet.net [47.154.29.181]) by mail.nomadlogic.org (OpenSMTPD) with ESMTPSA id 2fac6a6b (TLSv1.3:TLS_AES_256_GCM_SHA384:256:NO); Wed, 25 Mar 2026 15:14:03 +0000 (UTC) Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable From: Pete Wright List-Id: Packaging the FreeBSD base system List-Archive: https://lists.freebsd.org/archives/freebsd-pkgbase List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-freebsd-pkgbase@FreeBSD.org Mime-Version: 1.0 (1.0) Subject: Re: more pkgbase reviewers required Date: Wed, 25 Mar 2026 08:13:54 -0700 Message-Id: <7B32EC96-7D56-41B1-940F-DE3C84DE08E9@nomadlogic.org> References: Cc: hackers@freebsd.org, pkgbase@freebsd.org In-Reply-To: To: Lexi Winter X-Mailer: iPhone Mail (23E246) X-Rspamd-Pre-Result: action=no action; module=replies; Message is reply to one we originated X-Spamd-Result: default: False [-4.00 / 15.00]; REPLY(-4.00)[]; ASN(0.00)[asn:29802, ipnet:46.21.153.0/24, country:US] X-Rspamd-Queue-Id: 4fgr6C42Prz3CWj X-Spamd-Bar: ---- Sent from my iPhone > On Mar 25, 2026, at 7:52=E2=80=AFAM, Lexi Winter wrote: >=20 > =EF=BB=BFPete Wright wrote in <3536ba2d-ada0-4ebe-8e20-da94c9bc6fea@nomadl= ogic.org>: >>> On 3/25/26 05:54, Lexi Winter wrote: >>> at this point, it's extremely difficult to get any pkgbase-related >>> changes reviewed in Phabricator, which is an issue since we're now >>> pushing pkgbase as the default method for installing the system. >>> [...] >>=20 >> do you need to have a commit bit to be a useful reviewer. >=20 > no. although... i will say i tend to give more attention to reviews > from other committers. but it's not a requirement to be a committer > to review a change, and it's very helpful to get feedback from testing > (e.g., "this change broke my system!"), or to know that a particular > change might break existing deployments, for example. >=20 > but when considering whether to land a change, i only look at reviews > from committers. i.e., i might *not* land a change if non-committers > have objections, but i will not land a change if the only reviews are > from non-committers. >=20 > does that make sense? basically what i'm saying is, yes, it's useful > to get feedback on changes from people who aren't committers, but we > still need committers to actually land changes. > Understood - I=E2=80=99ll let yall with commit bits do your thing and get ou= t of the way since it sounds like it=E2=80=99ll just be noise. -Pete=