From owner-freebsd-ports@freebsd.org Fri Nov 2 10:28:45 2018 Return-Path: Delivered-To: freebsd-ports@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 6E7E110F1555 for ; Fri, 2 Nov 2018 10:28:45 +0000 (UTC) (envelope-from freebsd@omnilan.de) Received: from mx0.gentlemail.de (mx0.gentlemail.de [IPv6:2a00:e10:2800::a130]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id E51D781915 for ; Fri, 2 Nov 2018 10:28:44 +0000 (UTC) (envelope-from freebsd@omnilan.de) Received: from mh0.gentlemail.de (ezra.dcm1.omnilan.net [IPv6:2a00:e10:2800::a135]) by mx0.gentlemail.de (8.14.5/8.14.5) with ESMTP id wA2AShrx029461 for ; Fri, 2 Nov 2018 11:28:43 +0100 (CET) (envelope-from freebsd@omnilan.de) Received: from titan.inop.mo1.omnilan.net (s1.omnilan.de [217.91.127.234]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mh0.gentlemail.de (Postfix) with ESMTPSA id A07931B1 for ; Fri, 2 Nov 2018 11:28:43 +0100 (CET) Subject: Re: options DOCS + EXAMPLES From: Harry Schmalzbauer To: freebsd-ports@freebsd.org References: <07935967-fe29-c638-0bc3-2fd00cc9cee7@omnilan.de> Organization: OmniLAN Message-ID: <9e036794-0b16-5982-5919-8e84379ef525@omnilan.de> Date: Fri, 2 Nov 2018 11:28:43 +0100 User-Agent: Mozilla/5.0 (X11; FreeBSD amd64; rv:52.0) Gecko/20100101 Thunderbird/52.7.0 MIME-Version: 1.0 In-Reply-To: <07935967-fe29-c638-0bc3-2fd00cc9cee7@omnilan.de> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit Content-Language: en-US X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.2.7 (mx0.gentlemail.de [IPv6:2a00:e10:2800::a130]); Fri, 02 Nov 2018 11:28:43 +0100 (CET) X-Milter: Spamilter (Reciever: mx0.gentlemail.de; Sender-ip: ; Sender-helo: mh0.gentlemail.de; ) X-BeenThere: freebsd-ports@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Porting software to FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 02 Nov 2018 10:28:45 -0000 Am 02.11.2018 um 10:49 schrieb Harry Schmalzbauer: > Hello, > > found out that the need to define DOCS and EXAMPLES in OPTIONS_DEFINE > was made mandatory some time ago, which ports-mgmt/portlint isn't > aware about yet (found https://reviews.freebsd.org/D13036). > > I intentionally haven't defined it, because I want to make use of the > bsd.ports.mk handling of PORTDOCS and PORTEXAMPLES, but don't want to > spam the UI.  EXAMPLES and DOCS shall stay mandatory for my port, as > long as the user changes the corresponding defaults. > > How do I hide the user selection for EXAMPLES and DOCS after the > change (which I wasn't able to find by reading commit logs)? Confused bsd.port.options.mk with bsd.options.mk, so I found the corresponding commit (https://svnweb.freebsd.org/ports?view=revision&revision=479410). If a port has only a view DOCS and/or EXAMPLES files, consuming very little space, the user shouldn't get naged about installing it or not. The OPTIONS dialog is already real pain, where the user get's overloaded with hardly usable descriptions and without hints about consequences about changing different options – they all look the same while having enourmous different impact on change. Adding two completely meaningless choices (at least for my and many other ports I know) makes the dialog notably worse in my opinion. It does make absolutely no difference if myreadme.txt is in placed into a standards directory or not; even not on systems with very very limited inodes/space since pkg requires many orders of magnitudes more resources anyways, so the for sub½GB-setups, the public ports/pkg distribution isn't usable, hence the N indoes / N kb more ore less can't justify two more choices for _all_ ports which want to utilize %%PORTDOCS%% and %%PORTEXAMPLES%%. Of course there are ports where EXAMPLES or especially DOCS make a big difference, especially if DOCS require additional build dependencies. But these should be handled separatly instead of forcing all others to show never changing options. -harry