From owner-svn-src-all@freebsd.org Thu Apr 5 15:43:31 2018 Return-Path: Delivered-To: svn-src-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 44D00F8E973 for ; Thu, 5 Apr 2018 15:43:31 +0000 (UTC) (envelope-from wlosh@bsdimp.com) Received: from mail-it0-x22a.google.com (mail-it0-x22a.google.com [IPv6:2607:f8b0:4001:c0b::22a]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id C69F982866 for ; Thu, 5 Apr 2018 15:43:30 +0000 (UTC) (envelope-from wlosh@bsdimp.com) Received: by mail-it0-x22a.google.com with SMTP id h143-v6so3292908ita.4 for ; Thu, 05 Apr 2018 08:43:30 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bsdimp-com.20150623.gappssmtp.com; s=20150623; h=mime-version:sender:in-reply-to:references:from:date:message-id :subject:to:cc; bh=JtTQgxGl/eQurIde6fKwNkIW6kYqXxzOUsw68qZVqzk=; b=Bm5+KSJX5fIFe64ziuIROA4xG803fqMfhzGy+W4g2BF/wMjBvgql5IvN9s3PTcCpQ4 teqe2VfNRa8cEX/bO77XNWhx54FfglbOS4YgrieoEJLo72Zhy9dFKLAumY/h1deaMOsP rceixD1YaaSrXqBeNJj0FA5NgwpIFRH5FaKLKDGwKl1NMrSeXl3I9PqqtwD1LQubIX0Q C/gZc3GHmQZaH5foiKBkVTpzysBbAYPi/hUjdvwuE0txxALJmm1r6paOIKFLYhLp2JEL MsJMK51arUyDnCHL027QTD7qpKRBzHQl6J0I3YB7bqsm49VtAq0hMiJ6O1SPFUwhSGJD w6Wg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:sender:in-reply-to:references:from :date:message-id:subject:to:cc; bh=JtTQgxGl/eQurIde6fKwNkIW6kYqXxzOUsw68qZVqzk=; b=SX8eeiBH+VeGKtQDdk024j24AIY+c+UBIaAIPYzL7NEOwO3Fl0ljQwfI6RYCCuRJSK GhbzBgS5a94RkXlaTwC1ZfF0NTbZpxhQzk6g8l8FuxBAWRjNcPRJiWKr+z+uhGbdoAew WOlA8HgMIDi+lRDav4jC5fbc18KH7GpkAaYc0EfFK8MTTMb0ab4cm1gdkKsBYWtnW+DY yD2w7IDNq4NllVGM8qGS2RRfx3e0aFiRrn8L5tYPAhyxk5GMquVfw1lspU1aqdNqSHWo bmqw6aeUEt7rmYI1ZVh925/OQ8n7bg+BQZrEpvRxIFvUpq/peHBQCdv88O5AEUQ6Tb6k A7Hw== X-Gm-Message-State: ALQs6tCGzGIuObLTWeeFGKTo9As3cqcRfXhLl1SiuywLxC4mYllia8lp fN6jlRdu13auuDYkWtmUODAU7DGfddoQOUK42jvgxQ== X-Google-Smtp-Source: AIpwx497GNgdsNuJKj8qjZqMBZ/tCXjUbUo/Q6VaGXZyFXStOd+ExXBecOYHO7pjbl5m9J2GrkcZm9Dj2z3jYtoq3GY= X-Received: by 2002:a24:fa83:: with SMTP id v125-v6mr14339685ith.36.1522943010003; Thu, 05 Apr 2018 08:43:30 -0700 (PDT) MIME-Version: 1.0 Sender: wlosh@bsdimp.com Received: by 10.79.203.196 with HTTP; Thu, 5 Apr 2018 08:43:29 -0700 (PDT) X-Originating-IP: [2603:300b:6:5100:1052:acc7:f9de:2b6d] In-Reply-To: <20180405152204.GV1774@kib.kiev.ua> References: <201804040237.w342b5EA074884@repo.freebsd.org> <20180405152204.GV1774@kib.kiev.ua> From: Warner Losh Date: Thu, 5 Apr 2018 09:43:29 -0600 X-Google-Sender-Auth: ID164NBgfszhmEXs6zh8GE0cntA Message-ID: Subject: Re: svn commit: r331976 - head/sys/modules/cam To: Konstantin Belousov Cc: Warner Losh , src-committers , svn-src-all@freebsd.org, svn-src-head@freebsd.org Content-Type: text/plain; charset="UTF-8" X-Content-Filtered-By: Mailman/MimeDel 2.1.25 X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.25 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 05 Apr 2018 15:43:31 -0000 Thanks.... I'll attend to that. Warner On Thu, Apr 5, 2018 at 9:22 AM, Konstantin Belousov wrote: > On Wed, Apr 04, 2018 at 02:37:05AM +0000, Warner Losh wrote: > > Author: imp > > Date: Wed Apr 4 02:37:05 2018 > > New Revision: 331976 > > URL: https://svnweb.freebsd.org/changeset/base/331976 > > > > Log: > > Add nvme_da back. > > > > Now that it can co-exist in the kernel with nvd, add it back to the > > cam module. > > > > Sponsored by: Netflix > > > > Modified: > > head/sys/modules/cam/Makefile > > > > Modified: head/sys/modules/cam/Makefile > > ============================================================ > ================== > > --- head/sys/modules/cam/Makefile Wed Apr 4 02:35:48 2018 > (r331975) > > +++ head/sys/modules/cam/Makefile Wed Apr 4 02:37:05 2018 > (r331976) > > @@ -46,6 +46,7 @@ SRCS+= ata_machdep.c > > SRCS+= ata_pmp.c > > SRCS+= nvme_all.c > > SRCS+= nvme_xpt.c > > +SRCS+= nvme_da.c > > > > EXPORT_SYMS= YES # XXX evaluate > > This change resulted in the following: > > Preloaded elf obj module "/boot/kernel/cam.ko" at 0xffffffff812bb898. > link_elf_obj: symbol nvme_strvis undefined > KLD file cam.ko - could not finalize loading > KLD file ahci.ko - cannot find dependency "cam" >