From owner-cvs-all Sun Mar 17 17:33: 7 2002 Delivered-To: cvs-all@freebsd.org Received: from fledge.watson.org (fledge.watson.org [204.156.12.50]) by hub.freebsd.org (Postfix) with ESMTP id 8EC7F37B400; Sun, 17 Mar 2002 17:32:57 -0800 (PST) Received: from fledge.watson.org (fledge.pr.watson.org [192.0.2.3]) by fledge.watson.org (8.11.6/8.11.6) with SMTP id g2I1Wfk17026; Sun, 17 Mar 2002 20:32:41 -0500 (EST) (envelope-from robert@fledge.watson.org) Date: Sun, 17 Mar 2002 20:32:40 -0500 (EST) From: Robert Watson X-Sender: robert@fledge.watson.org To: Matthew Dillon Cc: Hiten Pandya , current@FreeBSD.ORG, cvs-all@FreeBSD.ORG, cvs-committers@FreeBSD.ORG, tanimura@r.dl.itc.u-tokyo.ac.jp Subject: Re: cvs commit: src/sys/kern kern_mtxpool.c src/sys/sys kernel.h src/sys/vm vm_fault.c vm_glue.c vm_map.c vm_map.h vm_pageout.c vm_zone.c In-Reply-To: <200203180048.g2I0mOc40231@apollo.backplane.com> Message-ID: MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: owner-cvs-all@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG On Sun, 17 Mar 2002, Matthew Dillon wrote: > It fixed some things, it broke some things. Pretty much standard > fare for anyone who has ever done work on the vm_map lock, including > yours truely. John Dyson couldn't get it right, David Greenman couldn't > get it right, I couldn't get it completely right... getting it to do > the right thing even under -stable is difficult, which is why I am > suggesting that it simply be made into an exclusive lock in -current. Hmm. Ok, so right now the code that has been branched for DP1 makes use of Brian's recent locking commits. My original thought was we'd simply back it out of that branch to make sure that the DP is reliable. How hard would it be for us to switch to what you propose (just convert all slocks into xlocks, and simplify out the upgrade semantics), in particular, before we cut the DP? It sounds to me like the right approach is simply to fall back to lockmgr for the DP, and get these fixes into the main tree and they'll be there for the next DP in a few months. Can you take ownership of the task since you clearly know what's going on? Can I stick your name in the smp web page saying so? :-) Robert N M Watson FreeBSD Core Team, TrustedBSD Project robert@fledge.watson.org NAI Labs, Safeport Network Services To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message