From owner-freebsd-wireless@FreeBSD.ORG Sun Mar 31 15:54:41 2013 Return-Path: Delivered-To: freebsd-wireless@freebsd.org Received: from mx1.freebsd.org (mx1.FreeBSD.org [8.8.178.115]) by hub.freebsd.org (Postfix) with ESMTP id B672091 for ; Sun, 31 Mar 2013 15:54:41 +0000 (UTC) (envelope-from gofdw-freebsd-wireless@m.gmane.org) Received: from plane.gmane.org (plane.gmane.org [80.91.229.3]) by mx1.freebsd.org (Postfix) with ESMTP id 76D871A6 for ; Sun, 31 Mar 2013 15:54:41 +0000 (UTC) Received: from list by plane.gmane.org with local (Exim 4.69) (envelope-from ) id 1UMKb2-0006CA-HW for freebsd-wireless@freebsd.org; Sun, 31 Mar 2013 17:55:04 +0200 Received: from a91-154-115-217.elisa-laajakaista.fi ([91.154.115.217]) by main.gmane.org with esmtp (Gmexim 0.1 (Debian)) id 1AlnuQ-0007hv-00 for ; Sun, 31 Mar 2013 17:55:04 +0200 Received: from rakuco by a91-154-115-217.elisa-laajakaista.fi with local (Gmexim 0.1 (Debian)) id 1AlnuQ-0007hv-00 for ; Sun, 31 Mar 2013 17:55:04 +0200 X-Injected-Via-Gmane: http://gmane.org/ To: freebsd-wireless@freebsd.org From: Raphael Kubo da Costa Subject: Re: [rft] ar9300 HAL updated Date: Sun, 31 Mar 2013 17:49:43 +0300 Lines: 43 Message-ID: <86bo9z39q0.fsf@orwell.Elisa> References: Mime-Version: 1.0 Content-Type: text/plain X-Complaints-To: usenet@ger.gmane.org X-Gmane-NNTP-Posting-Host: a91-154-115-217.elisa-laajakaista.fi User-Agent: Gnus/5.130006 (Ma Gnus v0.6) Emacs/24.3 (berkeley-unix) Cancel-Lock: sha1:2Y8vTz9yHd4R6AG+QoZTmhx5DaQ= X-BeenThere: freebsd-wireless@freebsd.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Discussions of 802.11 stack, tools device driver development." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 31 Mar 2013 15:54:41 -0000 Adrian Chadd writes: > I've just updated the AR9300 HAL to the March 13 snapshot from QCA. > > This includes calibration and TX power calibration changes that may > improve stability. > > As always, it's possible I broke something! > > I'd appreciate it if people would test this in STA and AP mode. I'm at r248944 here using HEAD. After checking out the code, I created the expected symlinks at the new contrib/ location (BTW, are you sure you want sys/contrib/sys/dev/ath instead of sys/contrib/dev/ath, which seems to be the chosen location for other modules?). The first error I got was in ar9300_radio.c:90 -- clang complained `ichan' was not being used. It is now failing like this: cc -O2 -pipe -fno-strict-aliasing -Werror -D_KERNEL -DKLD_MODULE -nostdinc -I. -I/usr/src/sys/modules/ath/../.. /dev/ath -I/usr/src/sys/modules/ath/../../dev/ath/ath_hal -I. -I/usr/src/sys/modules/ath/../../contrib/sys/dev/a th/ath_hal/ -DHAVE_KERNEL_OPTION_HEADERS -include /usr/obj/usr/src/sys/ORWELL/opt_global.h -I. -I@ -I@/contrib/a ltq -fno-common -g -fno-omit-frame-pointer -I/usr/obj/usr/src/sys/ORWELL -mno-aes -mno-avx -mcmodel=kernel -mno -red-zone -mno-mmx -mno-sse -msoft-float -fno-asynchronous-unwind-tables -ffreestanding -fstack-protector -std= iso9899:1999 -Qunused-arguments -fstack-protector -Wall -Wredundant-decls -Wnested-externs -Wstrict-prototypes -Wmissing-prototypes -Wpointer-arith -Winline -Wcast-qual -Wundef -Wno-pointer-sign -fformat-extensions -Wmiss ing-include-dirs -fdiagnostics-show-option -Wno-error-tautological-compare -Wno-error-empty-body -Wno-error-pa rentheses-equality -c /usr/src/sys/modules/ath/../../contrib/sys/dev/ath/ath_hal/ar9300/ar9300_eeprom.c In file included from /usr/src/sys/modules/ath/../../contrib/sys/dev/ath/ath_hal/ar9300/ar9300_eeprom.c:27: /usr/src/sys/modules/ath/../../contrib/sys/dev/ath/ath_hal/ar9300/ar9300template_generic.h:113:3: error: implicit conversion from 'int' to 'u_int8_t' (aka 'unsigned char') changes value from -477 to 35 [-Werror,-Wconstant-conversion] FREQ2FBIN(2412, 1), ^~~~~~~~~~~~~~~~~~ /usr/src/sys/modules/ath/../../contrib/sys/dev/ath/ath_hal/ar9300/ar9300eep.h:142:65: note: expanded from macro 'FREQ2FBIN' (((y) == HAL_FREQ_BAND_2GHZ) ? ((x) - 2300) : (((x) - 4800) / 5)) ~~~~~~~~~~~~~^~~ The error message is repeated multiple times (one for each FREQ2FBIN call).