From owner-freebsd-stable@FreeBSD.ORG Wed Apr 22 12:23:34 2015 Return-Path: Delivered-To: freebsd-stable@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id EEA7881B; Wed, 22 Apr 2015 12:23:34 +0000 (UTC) Received: from zxy.spb.ru (zxy.spb.ru [195.70.199.98]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id A7FBE1A27; Wed, 22 Apr 2015 12:23:34 +0000 (UTC) Received: from slw by zxy.spb.ru with local (Exim 4.84 (FreeBSD)) (envelope-from ) id 1Yktgi-00067J-73; Wed, 22 Apr 2015 15:23:32 +0300 Date: Wed, 22 Apr 2015 15:23:32 +0300 From: Slawa Olhovchenkov To: Glen Barber Cc: freebsd-stable@freebsd.org Subject: Re: bsdinstall support for multiple kernels Message-ID: <20150422122332.GI9114@zxy.spb.ru> References: <20150422111334.GS1394@zxy.spb.ru> <20150422111844.GA31769@hub.FreeBSD.org> <20150422112822.GT1394@zxy.spb.ru> <20150422115559.GB31769@hub.FreeBSD.org> <20150422120706.GH9114@zxy.spb.ru> <20150422121037.GC31769@hub.FreeBSD.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20150422121037.GC31769@hub.FreeBSD.org> User-Agent: Mutt/1.5.23 (2014-03-12) X-SA-Exim-Connect-IP: X-SA-Exim-Mail-From: slw@zxy.spb.ru X-SA-Exim-Scanned: No (on zxy.spb.ru); SAEximRunCond expanded to false X-BeenThere: freebsd-stable@freebsd.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: Production branch of FreeBSD source code List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 22 Apr 2015 12:23:35 -0000 On Wed, Apr 22, 2015 at 12:10:37PM +0000, Glen Barber wrote: > On Wed, Apr 22, 2015 at 03:07:06PM +0300, Slawa Olhovchenkov wrote: > > On Wed, Apr 22, 2015 at 11:55:59AM +0000, Glen Barber wrote: > > > > > On Wed, Apr 22, 2015 at 02:28:22PM +0300, Slawa Olhovchenkov wrote: > > > > On Wed, Apr 22, 2015 at 11:18:44AM +0000, Glen Barber wrote: > > > > > > bsdinstall don't ask about kernel.VSTREAM and don't install kernel.VSTREAM. > > > > > > > > > > > > What I miss? > > > > > > > > > > Currently, the installer only installs GENERIC. > > > > > > > > > > I have fixes for this in a projects branch, but it's not ready to merge > > > > > back to head just yet. (^/projects/release-install-debug if you're > > > > > interested.) > > > > > > > > I think also exist bug in scripts/make-manifest.sh: > > > > > > > > [...] > > > > eval: ${kernel....}: Bad substitution > > > > ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ > > > > > > Yes, you are correct. This is also fixed in the projects branch. > > > > O, I see. > > Can you also patch release/Makefile? > > > > === > > .if !empty(TARGET:M${_V}) > > OSRELEASE= ${TYPE}-${REVISION}-${BRANCH}-${TARGET} > > VOLUME_LABEL= ${REVISION:C/[.-]/_/g}_${BRANCH:C/[.-]/_/g}_${TARGET} > > .else > > OSRELEASE= ${TYPE}-${REVISION}-${BRANCH}-${TARGET}-${TARGET_ARCH} > > VOLUME_LABEL= ${REVISION:C/[.-]/_/g}_${BRANCH:C/[.-]/_/g}_${TARGET_ARCH} > > .endif > > === > > > > For BRANCH/REVISION like 10.1-RELEASE-p276179 label exceed limit: > > length(10_1_RELEASE_p281264_amd64_UEFIBO) = 33. > > > > I'm not sure there's much we really can do about this just yet. The > only solution I have for you at the moment is to set VOLUME_LABEL in > your build environment to exclude the patch version. may be just strip to max length in makefile? for prevent makefs fails. or do it in makefs (currently makefs failed, may be varning and striping best solutions?)