From owner-cvs-all@FreeBSD.ORG  Sun May 28 10:44:27 2006
Return-Path: <owner-cvs-all@FreeBSD.ORG>
X-Original-To: cvs-all@FreeBSD.ORG
Delivered-To: cvs-all@FreeBSD.ORG
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id E000516B590;
	Sun, 28 May 2006 10:43:02 +0000 (UTC) (envelope-from dds@aueb.gr)
Received: from mx-out-01.forthnet.gr (mx-out.forthnet.gr [193.92.150.30])
	by mx1.FreeBSD.org (Postfix) with ESMTP id 0F09243D48;
	Sun, 28 May 2006 10:43:01 +0000 (GMT) (envelope-from dds@aueb.gr)
Received: from mx-av-01.forthnet.gr (mx-av.forthnet.gr [193.92.150.27])
	by mx-out-01.forthnet.gr (8.13.6/8.13.6) with ESMTP id k4SAgxMh001068; 
	Sun, 28 May 2006 13:42:59 +0300
Received: from mx-in-04.forthnet.gr (mx-in-04.forthnet.gr [193.92.150.163])
	by mx-av-01.forthnet.gr (8.13.6/8.13.6) with ESMTP id k4SAgxTi022089;
	Sun, 28 May 2006 13:42:59 +0300
Received: from [192.168.136.16] (ppp76-181.adsl.forthnet.gr [195.74.246.181])
	by mx-in-04.forthnet.gr (8.13.6/8.13.6) with ESMTP id k4S8flbe025102;
	Sun, 28 May 2006 11:41:48 +0300
Authentication-Results: mx-in-04.forthnet.gr from=dds@aueb.gr;
	sender-id=neutral; spf=neutral
Message-ID: <44797EB7.60406@aueb.gr>
Date: Sun, 28 May 2006 13:43:03 +0300
From: Diomidis Spinellis <dds@aueb.gr>
User-Agent: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US;
	rv:1.8.0.2) Gecko/20060404 SeaMonkey/1.0.1
MIME-Version: 1.0
To: src-committers@FreeBSD.ORG
References: <200605280724.k4S7OCl5083567@repoman.freebsd.org>
In-Reply-To: <200605280724.k4S7OCl5083567@repoman.freebsd.org>
Content-Type: text/plain; charset=ISO-8859-7; format=flowed
Content-Transfer-Encoding: 7bit
Cc: cvs-src@FreeBSD.ORG, cvs-all@FreeBSD.ORG
Subject: Re: cvs commit: src/sys/kern vnode_if.src
X-BeenThere: cvs-all@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: CVS commit messages for the entire tree <cvs-all.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-all>,
	<mailto:cvs-all-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/cvs-all>
List-Post: <mailto:cvs-all@freebsd.org>
List-Help: <mailto:cvs-all-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-all>,
	<mailto:cvs-all-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Sun, 28 May 2006 10:44:30 -0000

Diomidis Spinellis wrote:
> dds         2006-05-28 07:24:12 UTC
> 
>   FreeBSD src repository
> 
>   Modified files:
>     sys/kern             vnode_if.src 
>   Log:
>   Add missing % signs in the lock annotations of the functions:
>   lookup, rename, strategy, islocked
>   The missing % sign meant that the lines were processed as plain
>   comments and the corresponding assertions were never generated.
>   
>   Revision  Changes    Path
>   1.80      +8 -8      src/sys/kern/vnode_if.src

To avoid this from happening again in the future, I intend to replace 
the "#!" and "#%" special comments that mark the pre- and 
post-conditions with a character sequence that can't be mistaken for a 
comment, and also add some error checking in the corresponding awk 
script.  If you have any strong objections please speak up within the 
coming week.

Diomidis - dds@