From owner-svn-src-all@freebsd.org Tue Oct 6 20:20:38 2015 Return-Path: Delivered-To: svn-src-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 330509D08DE; Tue, 6 Oct 2015 20:20:38 +0000 (UTC) (envelope-from adrian.chadd@gmail.com) Received: from mail-io0-x22c.google.com (mail-io0-x22c.google.com [IPv6:2607:f8b0:4001:c06::22c]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id EF6F5C65; Tue, 6 Oct 2015 20:20:37 +0000 (UTC) (envelope-from adrian.chadd@gmail.com) Received: by iofh134 with SMTP id h134so235788364iof.0; Tue, 06 Oct 2015 13:20:37 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type:content-transfer-encoding; bh=aRhY9y/etpsnLlJ0M8BWfVvo/eVEhIqy/8YVai+Tawk=; b=qvYZLY31VgO/y77wNLPJ/gwtHLr5sjE7xbgT1KuQSpEet8SJx+DWV95tGQyUhX9Ca5 2u6EhjNX14DD5wcT1wvm5CU7MCwM/cq46FTGJFdEnGySdsOCCy+ZCUwnH5H+cOutrjcz yIUWIt/bf2RMmsF+0RTcXEKtNPUmyTj9YoShM5oVvKqd9bbqr1SgOMi6JC5997tm/6xB R6R8yR3OYhMpCs2kBf1ik3fdvRrB9wePGAIavAd5etRYxHxNqoXPTymD/XlstjiH/s/E zLBECT6XFx99wJpQ6Dtuwr6hsX+AEOZYSF6TvASuktL5W0PtxSD0OqZZ4PWZa74lJ8fr nj6Q== MIME-Version: 1.0 X-Received: by 10.107.35.78 with SMTP id j75mr34752007ioj.123.1444162837407; Tue, 06 Oct 2015 13:20:37 -0700 (PDT) Received: by 10.36.46.15 with HTTP; Tue, 6 Oct 2015 13:20:37 -0700 (PDT) In-Reply-To: <56142CCC.7000807@FreeBSD.org> References: <201510040745.t947jbp7082807@repo.freebsd.org> <20151004094649.GG11284@kib.kiev.ua> <56142CCC.7000807@FreeBSD.org> Date: Tue, 6 Oct 2015 13:20:37 -0700 Message-ID: Subject: Re: svn commit: r288653 - in head/sys/dev/drm2: . i915 From: Adrian Chadd To: =?UTF-8?B?SmVhbi1Tw6liYXN0aWVuIFDDqWRyb24=?= Cc: Konstantin Belousov , Andriy Voskoboinyk , "src-committers@freebsd.org" , "svn-src-all@freebsd.org" , "svn-src-head@freebsd.org" Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 06 Oct 2015 20:20:38 -0000 ok, so what should we rip out? That '3' case? -a On 6 October 2015 at 13:19, Jean-S=C3=A9bastien P=C3=A9dron wrote: > On 04.10.2015 11:46, Konstantin Belousov wrote: >> On Sun, Oct 04, 2015 at 07:45:37AM +0000, Adrian Chadd wrote: >>> * Add missing case statement (gen =3D=3D 3) in intel_gpu_reset(). >> This seems to be wrong. The i915 and G33 chipsets do not have registers >> declared in the 8xx chipset documentation. More, i915 and G33 have diff= erent >> reset procedures. >> >> The absence of '3' case was copied from the corresponding Linux kernel. >> Was this change tested, or is there a reference to upstream where the >> handling was added in this manner ? > > You're right, even in Linux 3.8, the switch does not have a case for > generation 3. > >>> * Replace M_WAITOK with M_NOWAIT when the return value of malloc is c= hecked (may be incorrect). >> This is also incorrect. At least the modesetting pathes are executed in >> the syscall context, and sleeping is allowed; the modesetting locks were >> selected to make sleeping possible. Using nowait causes random syscalls >> failure where the requests would succeed otherwise. > > My reasoning was that M_WAITOK could make the display hang/unresponsive > while the memory is under pressure. The caller should be responsible for > handling the error instead. > > In Linux, *alloc() calls may fail so application should already be > responsible for that. > > -- > Jean-S=C3=A9bastien P=C3=A9dron >