Skip site navigation (1)Skip section navigation (2)
Date:      Sat, 22 Dec 2018 03:46:33 +0000
From:      bugzilla-noreply@freebsd.org
To:        ports-bugs@FreeBSD.org
Subject:   [Bug 234260] audio/hydrogen: Update to latest commit and switch to Qt 5
Message-ID:  <bug-234260-7788-erT0YKPjds@https.bugs.freebsd.org/bugzilla/>
In-Reply-To: <bug-234260-7788@https.bugs.freebsd.org/bugzilla/>
References:  <bug-234260-7788@https.bugs.freebsd.org/bugzilla/>

next in thread | previous in thread | raw e-mail | index | archive | help
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D234260

Tobias Kortkamp <tobik@freebsd.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|[maintainer update] for     |audio/hydrogen: Update to
                   |audio/hydrogen              |latest commit and switch to
                   |                            |Qt 5
             Status|New                         |Open
           Keywords|                            |needs-patch, needs-qa

--- Comment #1 from Tobias Kortkamp <tobik@freebsd.org> ---
Please keep compiler:c++11-lang!  It partially reverts ports r459300
for no reason and will probably break the build on powerpc64 again.

+/usr/share/pixmaps/h2-icon.svg
+@dir /usr/share/pixmaps

Something is wrong...

+DISTVERSION=3D   1.0.0.b1
+GH_TAGNAME=3D    538eaeb9f4e9 # master at 8/10

Please use git describe --tags to derive a proper version here:
https://www.freebsd.org/doc/en_US.ISO8859-1/books/porters-handbook/makefile=
-distfiles.html#makefile-master_sites-github-ex5

-do-test-TEST-on:
+do-test:

Why this change?  Is src/tests/tests also available when the port
is compiled with TEST=3Doff?

+USE_QT=3D        qmake buildtools core gui linguisttools network widgets x=
ml
xmlpatterns

Are qt5-buildtools, qt5-linguisttools, qt5-qmake really run
dependencies of Hydrogen?  Maybe something like this would be better:

USE_QT=3D core gui network widgets xml xmlpatterns buildtools_build
linguisttools_build qmake_build

Please confirm that this passes a Poudriere test build.

--=20
You are receiving this mail because:
You are the assignee for the bug.=



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?bug-234260-7788-erT0YKPjds>