From owner-svn-src-all@freebsd.org Sat Jul 30 01:07:21 2016 Return-Path: Delivered-To: svn-src-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id B56A7BA75F0 for ; Sat, 30 Jul 2016 01:07:21 +0000 (UTC) (envelope-from pfg@FreeBSD.org) Received: from nm27-vm1.bullet.mail.bf1.yahoo.com (nm27-vm1.bullet.mail.bf1.yahoo.com [98.139.213.148]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 619D21CB7 for ; Sat, 30 Jul 2016 01:07:21 +0000 (UTC) (envelope-from pfg@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048; t=1469840834; bh=rwwqOocnuolyarma6YaI1thlPozL5ccJojiUjPr/YLY=; h=Subject:To:References:Cc:From:Date:In-Reply-To:From:Subject; b=AkXW0LNtcotSTYwR6LfYf58lvJ1vXt5umjFYeoSa18qYILeWIZID1BityEjxtH8mz0ae4Tg84Wml8qOQf5f0TnoPFD+5iouR+8+/i7p7QExG4VSoL7606rHxzhSgo8ZIpmAKuMt6l/FDVzS8YczFXjej0Lvu1nMrQe41+LMjdCqPRxhVs6BGOelygHuMbxItoLj7aMgkLNMdUzUmXUlj+UlH9yhT21eYXon8xkQnTZ4LC7bUD0ZAJto60LoIYl6CyewNdYWcAOtYDZNSrZE5fXCuDA9kxnbJZSlweZZamx9Mtw2lQEfQeVIjwdXSoP161NE2+/1CbcjNWpzEMOixaA== Received: from [98.139.215.140] by nm27.bullet.mail.bf1.yahoo.com with NNFMP; 30 Jul 2016 01:07:14 -0000 Received: from [98.139.211.193] by tm11.bullet.mail.bf1.yahoo.com with NNFMP; 30 Jul 2016 01:07:14 -0000 Received: from [127.0.0.1] by smtp202.mail.bf1.yahoo.com with NNFMP; 30 Jul 2016 01:07:14 -0000 X-Yahoo-Newman-Id: 157790.69583.bm@smtp202.mail.bf1.yahoo.com X-Yahoo-Newman-Property: ymail-3 X-YMail-OSG: XmnWLkMVM1m_ZF0wZrmGFtaQs49PaejaL3nm1TROHTcNw9J Reo8hDIB_Lpgn6DFNjZu48ah1bT_Q1asN2kCIpjcjOdaC7rRT_Q8dJqC7UqT M94ioGKIKQNOTUVXU0SEx_hY4PuMPgl3Bf5A17CE6A3p41HUywcCXuI8V0p0 U.7Zc6E4GafuYMLDRfYHoScJXHlB.d4lH6SZrwrz8REmhtOeCKCDoZon7Lej .CaJ7NqGsxfpAR62PGPChBdr1iEoSDetdhVy7A8dg1Ew5PVzki56ZQPzqcUS 5JPKJ_4S2WGPQVcX2d_lVpmvPIv1bkjc7pQLfIsnI2HrSxGB.m5e_.qh9EUp TyV4coIc8B5MZt9NTYy69Sw4tA73tHqfrk8dq7miDW7Y7WK1Inl_uitHx8P. IzaN6FRHD9YdaM0wa49InOC8IHPfYosuXTN0R6eq7.UbfSkytsnKGcOtva6K qaDjogn0I.5O7WJ6gai3rDfhhrkZ3k5ZY1KlIRt2MfX01sTWKuuhwbup_kA6 DCvHfXP1biyTO8curKBzWRpW.TgjVA1DBtoi7.hCmuDTRtQ-- X-Yahoo-SMTP: xcjD0guswBAZaPPIbxpWwLcp9Unf Subject: Re: svn commit: r303502 - head/usr.bin/indent To: Bruce Evans References: <201607291936.u6TJaALj035130@repo.freebsd.org> <20160730092525.N1012@besplex.bde.org> Cc: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org From: Pedro Giffuni Message-ID: <8aa1f19c-3bdb-7acf-9cc1-66082cbbc400@FreeBSD.org> Date: Fri, 29 Jul 2016 20:07:21 -0500 User-Agent: Mozilla/5.0 (X11; FreeBSD amd64; rv:45.0) Gecko/20100101 Thunderbird/45.2.0 MIME-Version: 1.0 In-Reply-To: <20160730092525.N1012@besplex.bde.org> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.22 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 30 Jul 2016 01:07:21 -0000 On 07/29/16 19:00, Bruce Evans wrote: > On Fri, 29 Jul 2016, Pedro F. Giffuni wrote: > >> Log: >> indent(1): Use NULL instead of zero for pointers. > > This is probably not indent's style, I doubt that you found all of the > implicit NULLs. A recent commit added strstr() without even a comparison > with 0. > > This adds some lexical style bugs. > Yikes... hurry doesn't help get commits right. Sorry. Hope r303525 is not worse than what we had before. Pedro.