From owner-svn-src-all@freebsd.org Thu May 5 04:39:51 2016 Return-Path: Delivered-To: svn-src-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id D76F0B2D139; Thu, 5 May 2016 04:39:51 +0000 (UTC) (envelope-from adrian.chadd@gmail.com) Received: from mail-ig0-x22d.google.com (mail-ig0-x22d.google.com [IPv6:2607:f8b0:4001:c05::22d]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id A3FB216AE; Thu, 5 May 2016 04:39:51 +0000 (UTC) (envelope-from adrian.chadd@gmail.com) Received: by mail-ig0-x22d.google.com with SMTP id s8so5092014ign.0; Wed, 04 May 2016 21:39:51 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc; bh=LoFGA9gXiLF1hkFu4HqOmxQz5ObpKvhUBRFfvOLJhuk=; b=bwcV8MNc8yyBsDr2QP7DyrgdXy+aQQMzBOoyPN6rVt7tFs8SRkNVqqi2cDFD08SiF8 uuFhG70w0WkEKSZmvVCj6q9fce4loO7z/9Ria70N+xYD970Rpr2vfugJiKJh9i/G9BZC sCIH0TCUEgNjnj0DnEIkmmVsUOcdPVk4wnY8d0DRwoGwCrYP6Yq7D173iKWv0WfCk6EQ onkFwFWR/o0JWbk+SVSuxLTVCzeqiS2xAeNKKODNYuVgE37+EJRSsSnDnEsLeHPdEA25 0MJ4bxxMn9FGe7STThkVr8GVqY3hGzjkCoOGAMjrf/8nOhTy2sPzLd6s3/ycub/5j0mI 00bQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:date :message-id:subject:from:to:cc; bh=LoFGA9gXiLF1hkFu4HqOmxQz5ObpKvhUBRFfvOLJhuk=; b=b6wOGx3rvslrMuwU/mbznR1pmP3DP5vPgvSKJLFokH7WR8S7qOKcJHAImt/XOyt66x RJlRVlQGATgu04PKvMx0RwtfhnQYeaElPV0du1mx3kpFl//4biv8n2sUnPRVYMJzoXhI kHwAYf1YH5Yt29ThheLPr1kY92LdS8DpzDVdsL622gJffzgkYM1g2UK9O8mSi1XcHdna FWcrjVfS3x91R3AicYhedRdaokTwuaLVddQB1eWo1jyLO72Qc+7wbpZ94QroJ+8hB0nu gchdCbRHcRJzIBSliz679FpVT/O+A8/BrUXhMdO1TnTJvNmy3A+VLDQrRTtdWHmiW6O+ +E0w== X-Gm-Message-State: AOPr4FUj8PZ5ijvwVgnsrknO8PI0BgJIC6QG0isUh2H1TrnCDLH5ovDjhCxflj62Hi8lKzhTtQHpGzZXvm2qMA== MIME-Version: 1.0 X-Received: by 10.50.187.133 with SMTP id fs5mr1277256igc.61.1462423190961; Wed, 04 May 2016 21:39:50 -0700 (PDT) Received: by 10.36.113.3 with HTTP; Wed, 4 May 2016 21:39:50 -0700 (PDT) In-Reply-To: <2598444.C6bcyDe9AO@ralph.baldwin.cx> References: <201605050251.u452pVSN034598@repo.freebsd.org> <2598444.C6bcyDe9AO@ralph.baldwin.cx> Date: Wed, 4 May 2016 21:39:50 -0700 Message-ID: Subject: Re: svn commit: r299108 - head/sys/sys From: Adrian Chadd To: John Baldwin Cc: Garrett Cooper , "src-committers@freebsd.org" , "svn-src-all@freebsd.org" , "svn-src-head@freebsd.org" Content-Type: text/plain; charset=UTF-8 X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.22 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 05 May 2016 04:39:51 -0000 oops! sorry! -a On 4 May 2016 at 20:17, John Baldwin wrote: > On Thursday, May 05, 2016 02:51:31 AM Garrett Cooper wrote: >> Author: ngie >> Date: Thu May 5 02:51:31 2016 >> New Revision: 299108 >> URL: https://svnweb.freebsd.org/changeset/base/299108 >> >> Log: >> Revert r299096 >> >> The change broke buildworld when building lib/libkvm >> >> This change likely needs to be run through a ports -exp run as a sanity >> check, as it might break downstream consumers. >> >> Pointyhat to: adrian >> Reported by: kargl (confirmed on $work workstation) >> Sponsored by: EMC / Isilon Storage Division > > 'struct foo *' can be use with a simple forward declare in headers without > requiring header pollution (and is often done for that reason). device_t > should be used in any .c files, but headers might need to stick with > 'struct device *' in a few cases for that reason. I suspect both of these > fall into that category. > > -- > John Baldwin >