From owner-freebsd-ports-bugs@freebsd.org Sun Oct 15 23:01:23 2017 Return-Path: Delivered-To: freebsd-ports-bugs@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id AF0FFE4CE92 for ; Sun, 15 Oct 2017 23:01:23 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2001:1900:2254:206a::16:76]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 9C8E864322 for ; Sun, 15 Oct 2017 23:01:23 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from bugs.freebsd.org ([127.0.1.118]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id v9FN1L8w084145 for ; Sun, 15 Oct 2017 23:01:23 GMT (envelope-from bugzilla-noreply@freebsd.org) From: bugzilla-noreply@freebsd.org To: freebsd-ports-bugs@FreeBSD.org Subject: [Bug 223038] Update mail/opendkim: Fix rc script chmod Date: Sun, 15 Oct 2017 23:01:21 +0000 X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: new X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Ports & Packages X-Bugzilla-Component: Individual Port(s) X-Bugzilla-Version: Latest X-Bugzilla-Keywords: X-Bugzilla-Severity: Affects Only Me X-Bugzilla-Who: douglas@douglasthrift.net X-Bugzilla-Status: New X-Bugzilla-Resolution: X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: freebsd-ports-bugs@FreeBSD.org X-Bugzilla-Flags: maintainer-feedback? X-Bugzilla-Changed-Fields: bug_id short_desc product version rep_platform op_sys bug_status bug_severity priority component assigned_to reporter cc flagtypes.name attachments.created Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated MIME-Version: 1.0 X-BeenThere: freebsd-ports-bugs@freebsd.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Ports bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 15 Oct 2017 23:01:23 -0000 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D223038 Bug ID: 223038 Summary: Update mail/opendkim: Fix rc script chmod Product: Ports & Packages Version: Latest Hardware: Any OS: Any Status: New Severity: Affects Only Me Priority: --- Component: Individual Port(s) Assignee: freebsd-ports-bugs@FreeBSD.org Reporter: douglas@douglasthrift.net CC: freebsd-ports@dan.me.uk Attachment #187204 maintainer-approval?(freebsd-ports@dan.me.uk) Flags: CC: freebsd-ports@dan.me.uk Flags: maintainer-feedback?(freebsd-ports@dan.me.uk) Created attachment 187204 --> https://bugs.freebsd.org/bugzilla/attachment.cgi?id=3D187204&action= =3Dedit mail/opendkim-2.10.3_8.diff The comments in the milter-opendkim rc script state that milteropendkim_soc= ket is one of the parameters that can instead be set in opendkim.conf(5) config file. However, when running the rc script to start or restart the daemon, t= he usage for chmod is printed as if it was invoked with incorrect parameters. I tracked this down to milteropendkim_socket being unset and [ -S ... ] retur= ning 0 in sh if its argument is blank and unquoted in the dkim_start_postcmd function. I have provided a patch which avoids this by first checking if milteropendkim_socket is not blank. portlint: OK (0 fatal errors and 16 warnings found.) testport: OK (poudriere: 103i386, 103amd64, 111i386, 111amd64) --=20 You are receiving this mail because: You are the assignee for the bug.=