From owner-freebsd-security Mon Nov 13 13:54:45 1995 Return-Path: owner-security Received: (from root@localhost) by freefall.freebsd.org (8.6.12/8.6.6) id NAA02138 for security-outgoing; Mon, 13 Nov 1995 13:54:45 -0800 Received: from godzilla.zeta.org.au (godzilla.zeta.org.au [203.2.228.19]) by freefall.freebsd.org (8.6.12/8.6.6) with ESMTP id NAA02129 for ; Mon, 13 Nov 1995 13:54:37 -0800 Received: (from bde@localhost) by godzilla.zeta.org.au (8.6.9/8.6.9) id IAA08615; Tue, 14 Nov 1995 08:49:30 +1100 Date: Tue, 14 Nov 1995 08:49:30 +1100 From: Bruce Evans Message-Id: <199511132149.IAA08615@godzilla.zeta.org.au> To: peter@jhome.DIALix.COM, wollman@lcs.mit.edu Subject: Re: cvs commit: CVSROOT log_accum.pl Cc: security@FreeBSD.org Sender: owner-security@FreeBSD.org Precedence: bulk >> The order of cr_ngroups and cr_uid could be swapped making the whole >> thing 4 bytes smaller (assuming that I understand structure packing.. :-) >Better to make the shorts into longs if you're going to change the >structure. shorts are slow. Longs might be slow too. Use [unsigned] ints. I've seen reports that shorts (and chars?) are even slower (relatively) on the P6. I don't know why that would be - I would have thought that movsx and movzx were near the top of the list of things to optimize after the 486 optimized more important operations. Bruce