From owner-cvs-all Sun Jun 24 20:44:27 2001 Delivered-To: cvs-all@freebsd.org Received: from silby.com (cb34181-a.mdsn1.wi.home.com [24.14.173.39]) by hub.freebsd.org (Postfix) with ESMTP id EC30F37B407 for ; Sun, 24 Jun 2001 20:44:14 -0700 (PDT) (envelope-from silby@silby.com) Received: (qmail 1159 invoked by uid 1000); 25 Jun 2001 03:44:13 -0000 Received: from localhost (sendmail-bs@127.0.0.1) by localhost with SMTP; 25 Jun 2001 03:44:13 -0000 Date: Sun, 24 Jun 2001 22:44:13 -0500 (CDT) From: Mike Silbersack To: Alfred Perlstein Cc: Mike Silbersack , , , , Subject: Re: cvs commit: src/sys/netinet tcp_input.c tcp_output.c tcp_subr.c tcp_timer.c tcp_usrreq.c tcp_var.h In-Reply-To: <20010623102801.F57058@sneakerz.org> Message-ID: <20010624223750.Y1104-100000@achilles.silby.com> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: owner-cvs-all@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG On Sat, 23 Jun 2001, Alfred Perlstein wrote: > > Eliminate the allocation of a tcp template structure for each > > connection. The information contained in a tcptemp can be > > reconstructed from a tcpcb when needed. > > I may have missed it, but did you guys happen to run a perf test > on this along the same lines as the excellent work done to benchmark > the new mbuf allocator? I did runs of netperf -l 30 with all three cases (old, after my commit, after jlemon's commit), and there's no statistically observeable difference in performance. No big surprise there, the memory copies / zeros of the headers are probably dwarfed by the time spent copying the data. I suppose that the results would turn out differently on a heavily loaded system with thousands of mbufs allocated across hundreds of pages. I suspect that the new scheme w/o tcp templates would start to show improvements as the mbuf usage increased. But in any case, the decreased mbuf usage seems quite nice, and was the major motivation for the patch. Mike "Silby" Silbersack To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message