From owner-svn-src-head@freebsd.org Thu Feb 22 16:31:39 2018 Return-Path: Delivered-To: svn-src-head@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id A1CF9F144A2 for ; Thu, 22 Feb 2018 16:31:39 +0000 (UTC) (envelope-from wma@semihalf.com) Received: from mail-qt0-x234.google.com (mail-qt0-x234.google.com [IPv6:2607:f8b0:400d:c0d::234]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 392E96C130 for ; Thu, 22 Feb 2018 16:31:39 +0000 (UTC) (envelope-from wma@semihalf.com) Received: by mail-qt0-x234.google.com with SMTP id d8so7033838qtm.0 for ; Thu, 22 Feb 2018 08:31:39 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=semihalf-com.20150623.gappssmtp.com; s=20150623; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=xYTaE8Ed4qvkzf0pjc7PI+1LVKXFG7VDzQhfcMrR/TM=; b=Q10RKypB89FhEw9lCw8o3jRr5NOzJk0DxIL2JZQzLEzPM3CFqubdd0AYT4LIimUi5Y rzHy4i+OV6/CbXloTstUhx5cUDxV4roBMIgKlysq2sSnDxDXlQegCRSrI600kvqUWHy+ Ek1Q6D6KSrBBpAti15kJ/U8vtOYlpC4qiWal4L1qKkUGO2bi8mE++uovzGYz6uQAxZjC caff7etYMto9jKVwzne6neGe53O2HbPUx8KCyOzFUkhVur7bAo+E3nqib1U+QVgOjU3b 9Jrax/Vi3pzW2MKBDYkQoHmkxklDCM5ZLzg+G85OhwuxXIxe/QV77vPVFLctqKf7S+nP g+ZA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=xYTaE8Ed4qvkzf0pjc7PI+1LVKXFG7VDzQhfcMrR/TM=; b=CvYqd+F574lK3n+ICvyozZDEr2DdlinpfkuM9V5vsSIG4GGshk6VL8uLBOODmDTg4i Cr3yVEpo8mG1hgqElifF8knSEjqrrFyRhGRch5Yb67q3n4Z70Ux5RGu9w7XwZiDUx1wl 7hVwbgLjrTSZLp6zZK8bq31ESKNOf9rzTtnDorbp+IayIaQofTGG9l1qRMclQxv5njxo zMhDOlWMAVHpSRsijf7khvxgv8RhV58uuE3Zpb12G4CmBVSR5Wc3SEm8dGNZhcYqowAu i0E9KEfZpDufJOArOKnEFz6U3dPAOZ2PLbWYKp81hs7jC9VvyiB9xDp5N/UrpbInWOUY /W8w== X-Gm-Message-State: APf1xPAanyJivjFZ7j0YcqTS494muty7Dc5mjoaye5p8PZWqbM6Yw7uR vldEighDbZdxEfn+lne+UY8Ma+dAME0AH9DZji1ZPw== X-Google-Smtp-Source: AH8x226WiF9bw8KAxcSutNXYykpSL9UNMxyLXuyDq9OyFzQSC+TBruXF2cm8Qmfz0SYPvULafvUO9e19qiqFBCmtDkg= X-Received: by 10.200.3.110 with SMTP id w46mr11814795qtg.149.1519317098786; Thu, 22 Feb 2018 08:31:38 -0800 (PST) MIME-Version: 1.0 Received: by 10.200.56.170 with HTTP; Thu, 22 Feb 2018 08:31:18 -0800 (PST) In-Reply-To: References: <201802221332.w1MDWVao004564@repo.freebsd.org> From: Wojciech Macek Date: Thu, 22 Feb 2018 17:31:18 +0100 Message-ID: Subject: Re: svn commit: r329824 - in head: sbin/nvmecontrol sys/cam/nvme sys/conf sys/dev/mpr sys/dev/nvme To: Alan Somers Cc: Kyle Evans , Wojciech Macek , svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers Content-Type: text/plain; charset="UTF-8" X-Content-Filtered-By: Mailman/MimeDel 2.1.25 X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.25 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 22 Feb 2018 16:31:40 -0000 Thanks and sorry for troubles! These lines must have got lost somewhere during rebase as we run tinderbox with this patch yesterday. Regards, Wojtek wma@ 2018-02-22 17:22 GMT+01:00 Alan Somers : > On Thu, Feb 22, 2018 at 9:20 AM, Kyle Evans wrote: > >> On Thu, Feb 22, 2018 at 10:19 AM, Alan Somers >> wrote: >> > On Thu, Feb 22, 2018 at 6:32 AM, Wojciech Macek >> wrote: >> > >> >> Author: wma >> >> Date: Thu Feb 22 13:32:31 2018 >> >> New Revision: 329824 >> >> URL: https://svnweb.freebsd.org/changeset/base/329824 >> >> >> >> Log: >> >> NVMe: Add big-endian support >> >> >> >> Remove bitfields from defined structures as they are not portable. >> >> Instead use shift and mask macros in the driver and nvmecontrol >> >> application. >> >> >> >> NVMe is now working on powerpc64 host. >> >> >> >> Submitted by: Michal Stanek >> >> Obtained from: Semihalf >> >> Reviewed by: imp, wma >> >> Sponsored by: IBM, QCM Technologies >> >> Differential revision: https://reviews.freebsd.org/D13916 >> >> >> > >> > It looks like this change broke the build with Clang: >> > >> >> Fixed in r329827... all little endian arch's broken, not so great. =( >> > > Fast work, Kyle. Thanks a bundle. > -Alan >