Skip site navigation (1)Skip section navigation (2)
Date:      Fri, 09 Sep 1994 10:33:05 -0700
From:      Gary Palmer (FreeBSD/ARM Team) <gpalmer@freefall.cdrom.com>
To:        "Rodney W. Grimes" <rgrimes@gndrsh.aac.dev.com>
Cc:        jkh@freefall.cdrom.com (Jordan K. Hubbard), ache@freefall.cdrom.com, adam@freefall.cdrom.com, alm@freefall.cdrom.com, ats@freefall.cdrom.com, bde@freefall.cdrom.com, csgr@freefall.cdrom.com, cvs-games@freefall.cdrom.com, davidg@freefall.cdrom.com, dfr@freefall.cdrom.com, dyson@freefall.cdrom.com, gclarkii@freefall.cdrom.com, guido@freefall.cdrom.com, hsu@freefall.cdrom.com, joerg@freefall.cdrom.com, julian@freefall.cdrom.com, jvh@freefall.cdrom.com, karl@freefall.cdrom.com, martin@freefall.cdrom.com, nate@freefall.cdrom.com, paul@freefall.cdrom.com, phk@freefall.cdrom.com, proven@freefall.cdrom.com, pst@freefall.cdrom.com, rgrimes@freefall.cdrom.com, rich@freefall.cdrom.com, se@freefall.cdrom.com, sean@freefall.cdrom.com, sef@freefall.cdrom.com, smace@freefall.cdrom.com, sos@freefall.cdrom.com, torstenb@freefall.cdrom.com, wollman@freefall.cdrom.com
Subject:   Re: cvs commit: src/games/x11 Makefile 
Message-ID:  <15514.779131985@freefall.cdrom.com>
In-Reply-To: Your message of "Fri, 09 Sep 94 10:24:02 PDT." <199409091724.KAA11750@gndrsh.aac.dev.com> 

next in thread | previous in thread | raw e-mail | index | archive | help
In message <199409091724.KAA11750@gndrsh.aac.dev.com>, "Rodney W. Grimes" write
s:
>Now WHO submitted it?  And who reviewed it?  Can we slow down a little and
>be more carefull.  Quite a bit of my time last night was spent cleaning up
>behind others :-(.

>I am NOT meaning this directed towards you Jordan, it applies to many of
>the commit access people.  [Even I blew a few of the submit/review lines
>last night.

Right - can I be clear about this point please? If I make a trivial bug fix,
I nuke both the 'Submitted by:' and 'Reviewed By:' lines. If I make
a non-trivial change to the system, I get someone else to check it
over first, then put their (freefall e-mail addr?) in the Reviewed By: line?
If someone asks me (unlikely, but possible) to make a change, I put their
e-mail addr & name on the 'Submitted By:' line? Do I also add my addr to
the Reviewed By: line (assuming I did the sensible thing and checked it
before doing a cvs commit)?

Thanks

Gary (a cvs newbie)



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?15514.779131985>