Date: Fri, 11 Apr 2003 20:30:06 -0700 (PDT) From: "Scot W. Hetzel" <hetzels@westbend.net> To: freebsd-ports-bugs@FreeBSD.org Subject: Re: ports/50840: mail/squirrelmail - Port Docs in wrong location Message-ID: <200304120330.h3C3U6o9042097@freefall.freebsd.org>
next in thread | raw e-mail | index | archive | help
The following reply was made to PR ports/50840; it has been noted by GNATS.
From: "Scot W. Hetzel" <hetzels@westbend.net>
To: "Adam Weinberger" <adamw@freebsd.org>
Cc: <FreeBSD-gnats-submit@freebsd.org>, <simond@irrelevant.org>
Subject: Re: ports/50840: mail/squirrelmail - Port Docs in wrong location
Date: Fri, 11 Apr 2003 22:22:56 -0500
From: "Adam Weinberger" <adamw@freebsd.org>
> >> (04.11.2003 @ 1558 PST): Scot W. Hetzel said, in 67K: <<
> > +PLIST_SUB+= PORTVERSION=${PORTVERSION}
> > +
> > +DOCS= AUTHORS COPYING ChangeLog INSTALL README
ReleaseNotes-${PORTVERSION} UPGRADE
> > +
> > +post-extract:
> > + @${MV} ${WRKSRC}/ReleaseNotes ${WRKSRC}/ReleaseNotes-${PORTVERSION}
>
> Why are you doing this? Why do you want to alter the build mechanism to
> make a PORTVERSION-specific Relnotes file, if it just gets deleted on
> upgrade anyway?
>
> You're altering what the author intended. If you'd like to see
> ReleaseNotes renamed, please contact the author.
>
The reason for the rename of the ReleaseNotes file is that it would have
conflicted with the ReleaseNotes directory found under squirlmail/doc (when
it gets moved to the DOCSDIR). Other ports also rename files when they
install them into thier DOCSDIR to prevent name conflicts.
> So you're suggesting that:
> (1) The same files get installed anyway.
> (2) Then the doc files are deleted.
> (3) Then the entire doc/ directory is deleted
> (4) Then they're conditionally added back in
under the DOCSDIR.
>
> This makes assumptions about that people haven't put into their
> squirrelmail directory.
This makes the SquirrelMail Port conform to the FreeBSD Specification for
the location of Port Documentation.
http://www.fr.freebsd.org/doc/en_US.ISO8859-1/books/porters-handbook/dads-do
cumentation.html
> I'd personally rather see a list of files to install generated
> dynamically within the Makefile by listing ${WRKSRC} and then :S'ing out
> the doc/ directory from that list.
>
Submit a better patch to this PR that moves the files to their correct
locations.
> Also, I disagree that this should automatically go under /usr/local/www.
> I'm interested in hearing the maintainer's thoughts.
>
My thinking on this is that all web pages should be placed in one location
and since we already have the www directory (from the apache install)
available for web pages, this would be the best location for these files.
Instead of placing them under the PREFIX directory.
But I'll leave it up to the port maintainer/committer to decide on where the
proper location should be.
Scot
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200304120330.h3C3U6o9042097>